Fix interceptors receiving incorrect headers #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix tektoncd#391 Fixes the error where sometimes headers added to "webhook interceptors" would not be properly routed to the interceptor. The error was due to processing each request as a pointer. Thanks @dibbles for figuring out what was going wrong :) This PR includes a test case to catch the error.
tekton-robot
added
the
size/L
|
/lgtm |
dibyom
approved these changes
Jan 29, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dibyom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
ncskier
pushed a commit
to ncskier/triggers
that referenced
this pull request
Jan 29, 2020
Remove debug print statement in `sink_test.go`. Cleanup from PR tektoncd#393.
3 tasks
tekton-robot
pushed a commit
that referenced
this pull request
Jan 29, 2020
Remove debug print statement in `sink_test.go`. Cleanup from PR #393.
3 tasks
dibyom
pushed a commit
to dibyom/triggers
that referenced
this pull request
Jan 29, 2020
Remove debug print statement in `sink_test.go`. Cleanup from PR tektoncd#393.
dibyom
pushed a commit
to dibyom/triggers
that referenced
this pull request
Jan 29, 2020
Remove debug print statement in `sink_test.go`. Cleanup from PR tektoncd#393.
tekton-robot
pushed a commit
that referenced
this pull request
Jan 29, 2020
Remove debug print statement in `sink_test.go`. Cleanup from PR #393.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fix #391
Fixes the error where sometimes headers added to "webhook interceptors"
would not be properly routed to the interceptor.
The error was due to processing each request as a pointer. Thanks
@dibbles for figuring out what was going wrong :)
This PR includes a test case to catch the error.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.