Add BitBucket Interceptor with examples and README #578

savitaashture · 2020-05-14T19:08:20Z

Changes

Added BitBucket Interceptor
Added examples with README
Updated existing doc

Fixes: #362

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

Includes tests (if functionality changed/added)
Includes docs (if user facing)
Commit messages follow commit message best practices

See the contribution guide for more details.

Release Notes

- Added BitBucket Interceptors

tekton-robot · 2020-05-14T19:10:01Z

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/triggers/v1alpha1/event_listener_validation.go	92.9%	93.1%	0.2
pkg/interceptors/bitbucket/bitbucket.go	Do not exist	85.2%
pkg/sink/sink.go	74.0%	74.3%	0.3

tekton-robot · 2020-05-15T04:59:01Z

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/triggers/v1alpha1/event_listener_validation.go	92.9%	93.1%	0.2
pkg/interceptors/bitbucket/bitbucket.go	Do not exist	85.2%
pkg/sink/sink.go	74.0%	74.3%	0.3

tekton-robot · 2020-05-15T08:03:29Z

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/triggers/v1alpha1/event_listener_validation.go	92.9%	93.1%	0.2
pkg/interceptors/bitbucket/bitbucket.go	Do not exist	85.2%
pkg/sink/sink.go	74.0%	74.3%	0.3

tekton-robot · 2020-05-15T12:44:29Z

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/triggers/v1alpha1/event_listener_validation.go	92.9%	93.1%	0.2
pkg/interceptors/bitbucket/bitbucket.go	Do not exist	85.2%
pkg/sink/sink.go	74.0%	74.3%	0.3

docs/eventlisteners.md

tekton-robot · 2020-05-16T13:14:28Z

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/triggers/v1alpha1/event_listener_validation.go	92.9%	93.1%	0.2
pkg/interceptors/bitbucket/bitbucket.go	Do not exist	85.2%
pkg/sink/sink.go	74.0%	74.3%	0.3

dibyom

Thanks for adding this @savitaashture I have a few minor comments mostly around organizing the examples and docs. In addition, could you also squash the commits, and mention the issue in the commit message (https://github.com/tektoncd/community/blob/master/standards.md#commit-messages)

dibyom · 2020-05-18T20:26:01Z

pkg/apis/triggers/v1alpha1/event_listener_validation.go

+	// No bitbucket validation required yet.
+	// if i.Bitbucket != nil {
+	//
+	// }


Don't think this is necessary?

Also, we should add validation for these 😄 (maybe in a future PR)

Can we remove the commented out code?

pkg/interceptors/bitbucket/bitbucket_test.go

pkg/sink/sink_test.go

examples/bitbucket/README.md

examples/bitbucket/bitbucket-eventlistener-interceptor.yaml

examples/bitbucket/pipeline.yaml

examples/bitbucket/secret.yaml

examples/bitbucket/role.yaml

tekton-robot · 2020-05-20T12:21:02Z

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/triggers/v1alpha1/event_listener_validation.go	92.9%	93.1%	0.2
pkg/interceptors/bitbucket/bitbucket.go	Do not exist	85.2%
pkg/sink/sink.go	74.0%	74.3%	0.3

dibyom

Almost there, just a few small nits!

dibyom · 2020-05-27T22:06:57Z

pkg/apis/triggers/v1alpha1/event_listener_validation.go

+	// No bitbucket validation required yet.
+	// if i.Bitbucket != nil {
+	//
+	// }


Can we remove the commented out code?

dibyom · 2020-05-27T22:07:50Z

pkg/apis/triggers/v1alpha1/event_listener_validation_test.go

-						GitLab: &v1alpha1.GitLabInterceptor{},
+						GitHub:    &v1alpha1.GitHubInterceptor{},
+						GitLab:    &v1alpha1.GitLabInterceptor{},
+						Bitbucket: &v1alpha1.BitBucketInterceptor{},


I don't think adding it here is doing anything since this is just testing the validation fails with multiple interceptors

@dibyom I forgot to mention that adding BitBucket here will cover this scenario
The point of adding here is to cover the unit test.
I have reverted back by adding BitBucket

Let me know on this

hmm, seems ok for now but wondering if we should have a separate test for that...

pkg/interceptors/cel/cel_test.go

pkg/interceptors/github/github_test.go

pkg/interceptors/gitlab/gitlab_test.go

tekton-robot · 2020-06-01T18:46:08Z

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/triggers/v1alpha1/event_listener_validation.go	92.9%	91.4%	-1.5
pkg/interceptors/bitbucket/bitbucket.go	Do not exist	85.2%
pkg/sink/sink.go	74.0%	74.3%	0.3

dibyom · 2020-06-01T20:01:27Z

Excellent. Thank you @savitaashture Could you squash up the 2 commits and we can merge!
/approve

tekton-robot · 2020-06-01T20:01:31Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [dibyom]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

tekton-robot · 2020-06-02T04:19:06Z

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/triggers/v1alpha1/event_listener_validation.go	92.9%	93.1%	0.2
pkg/interceptors/bitbucket/bitbucket.go	Do not exist	85.2%
pkg/sink/sink.go	74.0%	74.3%	0.3

dibyom · 2020-06-02T21:05:01Z

/lgtm

tekton-robot · 2020-06-03T14:13:43Z

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/triggers/v1alpha1/event_listener_validation.go	92.9%	93.1%	0.2
pkg/interceptors/bitbucket/bitbucket.go	Do not exist	85.2%
pkg/sink/sink.go	74.0%	74.3%	0.3

tekton-robot · 2020-06-03T14:20:15Z

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/triggers/v1alpha1/event_listener_validation.go	92.9%	93.1%	0.2
pkg/interceptors/bitbucket/bitbucket.go	Do not exist	85.2%
pkg/sink/sink.go	74.0%	74.3%	0.3

dibyom · 2020-06-03T14:40:33Z

/lgtm

tekton-robot requested review from iancoffey and ncskier May 14, 2020 19:08

tekton-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label May 14, 2020

savitaashture force-pushed the bitbucket-interceptors branch from 61fc8e9 to b669685 Compare May 15, 2020 04:57

savitaashture force-pushed the bitbucket-interceptors branch from b669685 to b4e4e56 Compare May 15, 2020 08:01

savitaashture force-pushed the bitbucket-interceptors branch from b4e4e56 to 72651bb Compare May 15, 2020 12:42

jlpettersson reviewed May 15, 2020

View reviewed changes

docs/eventlisteners.md Outdated Show resolved Hide resolved

docs/eventlisteners.md Outdated Show resolved Hide resolved

dibyom reviewed May 18, 2020

View reviewed changes

dibyom mentioned this pull request May 18, 2020

Refactored examples and added github example with README #576

Merged

3 tasks

savitaashture force-pushed the bitbucket-interceptors branch from baeca7b to d208426 Compare May 20, 2020 12:19

dibyom reviewed May 27, 2020

View reviewed changes

tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 1, 2020

savitaashture force-pushed the bitbucket-interceptors branch from 19cdcae to c8896b9 Compare June 2, 2020 04:17

tekton-robot assigned dibyom Jun 2, 2020

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 2, 2020

savitaashture force-pushed the bitbucket-interceptors branch from c8896b9 to 33d06b7 Compare June 3, 2020 14:11

tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Jun 3, 2020

Add BitBucket Interceptor with examples and README

6bbe4b7

savitaashture force-pushed the bitbucket-interceptors branch from 33d06b7 to 6bbe4b7 Compare June 3, 2020 14:18

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 3, 2020

tekton-robot merged commit dd1aff6 into tektoncd:master Jun 3, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add BitBucket Interceptor with examples and README #578

Add BitBucket Interceptor with examples and README #578

savitaashture commented May 14, 2020 •

edited

Loading

tekton-robot commented May 14, 2020

tekton-robot commented May 15, 2020

tekton-robot commented May 15, 2020

tekton-robot commented May 15, 2020

tekton-robot commented May 16, 2020

dibyom left a comment

dibyom May 18, 2020

dibyom May 18, 2020

dibyom May 27, 2020

tekton-robot commented May 20, 2020

dibyom left a comment

dibyom May 27, 2020

dibyom May 27, 2020

savitaashture Jun 2, 2020 •

edited

Loading

dibyom Jun 2, 2020

tekton-robot commented Jun 1, 2020

dibyom commented Jun 1, 2020

tekton-robot commented Jun 1, 2020

tekton-robot commented Jun 2, 2020

dibyom commented Jun 2, 2020

tekton-robot commented Jun 3, 2020

tekton-robot commented Jun 3, 2020

dibyom commented Jun 3, 2020

Add BitBucket Interceptor with examples and README #578

Add BitBucket Interceptor with examples and README #578

Conversation

savitaashture commented May 14, 2020 • edited Loading

Changes

Submitter Checklist

Release Notes

tekton-robot commented May 14, 2020

tekton-robot commented May 15, 2020

tekton-robot commented May 15, 2020

tekton-robot commented May 15, 2020

tekton-robot commented May 16, 2020

dibyom left a comment

Choose a reason for hiding this comment

dibyom May 18, 2020

Choose a reason for hiding this comment

dibyom May 18, 2020

Choose a reason for hiding this comment

dibyom May 27, 2020

Choose a reason for hiding this comment

tekton-robot commented May 20, 2020

dibyom left a comment

Choose a reason for hiding this comment

dibyom May 27, 2020

Choose a reason for hiding this comment

dibyom May 27, 2020

Choose a reason for hiding this comment

savitaashture Jun 2, 2020 • edited Loading

Choose a reason for hiding this comment

dibyom Jun 2, 2020

Choose a reason for hiding this comment

tekton-robot commented Jun 1, 2020

dibyom commented Jun 1, 2020

tekton-robot commented Jun 1, 2020

tekton-robot commented Jun 2, 2020

dibyom commented Jun 2, 2020

tekton-robot commented Jun 3, 2020

tekton-robot commented Jun 3, 2020

dibyom commented Jun 3, 2020

savitaashture commented May 14, 2020 •

edited

Loading

savitaashture Jun 2, 2020 •

edited

Loading