Add a new CRD type called Trigger

[dorismeixing]

Changes

/kind misc

Adds the Trigger type. It has not been wired up and cannot be used yet.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

• Includes tests (if functionality changed/added)
• Includes docs (if user facing)
• Commit messages follow commit message best practices

See the contribution guide for more details.

[dorismeixing]

add reviewer @dibyom

[khrm]

I feel in first iteration, we should only have TriggersCRD which can be used as ref inside the EventListener Spec.

[dorismeixing]

/retest

[khrm]

Please add appropriate role also here:
https://github.com/tektoncd/triggers/blob/master/config/200-clusterrole.yaml

[dibyom]

/test pull-tekton-triggers-integration-tests

[dibyom]

The integration test failure looks unrelated.
Once you address @khrm 's comment and squash the two commits into one, we are good to go!

[dibyom]

/lgtm

[wlynch]

Do we know why the data in third_party was deleted? IIRC we need this to include license information in released images via kodata

[dibyom]

Do we know why the data in third_party was deleted? IIRC we need this to include license information in released images via kodata

FWIW, when I run ./hack/update-deps.sh on master, I get the same result i.e. the same license files are deleted 🙃

[dibyom]

I opened #653 to track the LICENSE removal bug.

[wlynch]

/lgtm
/approval

[wlynch]

/approve

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wlynch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [wlynch]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[bobcatfish]

Hey @dorismeixing @wlynch @dibyom a few requests:

• Is there a design doc and/or issue that accompanies this?
• Can there be usage docs on how to use this?

[dorismeixing]

Hi @bobcatfish, I think it's related to #624 and it will be used in Trigger CLI, but I am not sure if there is a design doc. I can add an usage doc if needed.

[bobcatfish]

Hey @dorismeixing !

I think it's related to #624 and it will be used in Trigger CLI

Looking at #624 I don't see a design doc there either 🤔 I'm a bit surprised that we'd add a new CRD without a design doc - maybe @wlynch or @dibyom when he's back have more info?

I can add an usage doc if needed.

yes plz :D usually we try to accompany every commit with the related docs changes (https://github.com/tektoncd/community/blob/master/standards.md#principles), so since we've added a new type here I'd expect to see some docs at https://github.com/tektoncd/triggers/tree/master/docs about how to use it

[dibyom]

Triggers WG has been discussing a Trigger CRD in https://docs.google.com/document/d/1NX0ExhPad6ixTM8AdU0b6Vc3MVD5hQ_vIrOs9dIXq-I/edit# and https://docs.google.com/document/d/1zWpmEhtSNe8KAPKvTJE7Pjg5Uzk8mx9MUjSN24D1jUg/edit#

We reached consensus on a Trigger CRD + selector approach in the Triggers WG and a TEP has been filed with the proposed approach: tektoncd/community#148

This PR adds the type but it is not ready to be used by an end user yet. The main motivation for adding the type now was to simplify the run CLI tool while we worked out the open questions/TEP process for the overall Trigger/Selector approach. The CRD will be usable once we either have the run CLI implemented or we implement the approach from the TEP.

(One thing is that we haven't been very good at updating the GitHub issues with the status of our discussion from the WGs/docs -- I'll update the issues)