This repository has been archived by the owner on Dec 4, 2018. It is now read-only.
Added delegate to TLYShyNavBarManager #103
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nsion finishes animating.
…came fully contracted.
Add support for carthage
better shield link
# Conflicts: # TLYShyNavBar/TLYShyNavBarManager.h # TLYShyNavBar/TLYShyNavBarManager.m
|
Awesome, definitely interested in this, thanks!! However, it's really hard to merge this PR with all these changes, can you please rebase or make one with minimal changes? For example, your PR affects the readme shields, which is obviously an error |
|
@gfzabarino Sorry for the confusion, I just deleted the develop branch, since it isn't actually used. Care to submit a PR against master? |
|
Done, here it is: #106 |
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, sorry about the blank lines that got changed with spaces, I'm using AppCode, and it has a bug with that.
Thanks for this component, it's working great for me, specially the latest changes you added.
About the PR, I'm using this delegate on a project and it's working fine. I actually made my work against master, but I figured you wanted code to be merged to the develop branch.
Let me know what do you think. Thanks.