This repository has been archived by the owner on Dec 4, 2018. It is now read-only.
Fix refresh #122
Merged
Fix refresh #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow, superb work! I never thought of going with that approach, thanks for submitting this. I'll give it a shot, and merge it ASAP. Hopefully then, make a new release with this being the main new feature :D |
|
Awesome, thanks. Yea definitely give it a run through, seems to work well for my situation but seeing other situations tested would be great. |
|
Tried this out in my project and it works great. |
|
Good to hear. Thanks for trying it out. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this could be a clean fix for the refresh control issue found here: #99
What it does
This checks to see if any of the subviews of the scrollview being set is of type UIRefreshControl. If it is it sets a new property on the shyscrollviewcontroller equal to that refresh control. If the refreshControl is nil (a scrollview without pull to refresh) the code behaves the same (still calling tly_setInsets), if the refreshControl exists it only calls tly_setInsets if the refreshControl is hidden. I tried to check if the refreshControl was refreshing but that check is too late. This PR will make it so when the pull to refresh appears (user is thinking about refreshing) we will no longer layout the views. It seems to work on my end.