This repository has been archived by the owner on Dec 4, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 426
UIPageViewController support, scaling & new delegate methods #166
Open
Coledunsby
wants to merge
26
commits into
telly:master
Choose a base branch
from
Coledunsby:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
b4e5d88
scale behaviour
509a09a
typos
d02e23d
removed KVO
6e31e63
fixed delegate
b66f91b
TLYShyViewControllerDelegate
4828101
cleanup
1fcc965
calculateTotalHeightRecursively & calculateBottomRecursively
f6d37c8
readonly contracted & expanded
61626b6
finish animation before overlapping status bar
28ed3c8
height
a3e182f
readonly contracting
7cb7900
removed viewWillLayoutSubviews swizzle
db5a180
removed applicationDidChangeStatusBarFrame
adaf221
bottom
e804c46
isMidTransition
640c27b
scrolling
e5afba4
removed layoutViews
f0e0751
automaticallyAdjustsScrollViewInsets
0701fa7
more delegate methods
403e10f
Revert "removed applicationDidChangeStatusBarFrame"
1b0ac3a
removed `scrolling` property
c688f24
Merge branch 'master-upstream'
08f2481
cleanup for PR
e6f3d3e
fix top inset when setting scroll view
30cea89
Merge remote-tracking branch 'upstream/master'
3e5db74
removed viewOverlapsStatusBar check
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This a better way to check if it's a modal. The current implementation fails in some cases (e.g. if a
UITabBarController
is pushed onto aUIViewController
).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Coledunsby @telly Should be fixed in main repo! Thanks for your PR.