Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disconnect peer properly in consensus #1613

Closed
melekes opened this issue May 23, 2018 · 1 comment
Closed

Disconnect peer properly in consensus #1613

melekes opened this issue May 23, 2018 · 1 comment
Labels
C:consensus Component: Consensus C:p2p Component: P2P pkg
Milestone
Wishlist

Comments

@melekes
Copy link
Contributor

melekes commented May 23, 2018

tendermint/consensus/reactor.go

Lines 164 to 170 in 114e735

func (conR *ConsensusReactor) RemovePeer(peer p2p.Peer, reason interface{}) {
if !conR.IsRunning() {
return
}
// TODO
//peer.Get(PeerStateKey).(*PeerState).Disconnect()
}

@melekes melekes added the C:consensus Component: Consensus label May 23, 2018
@xla xla changed the title [consensus] TODO: peer.Get(PeerStateKey).(*PeerState).Disconnect() Disconnect peer properly in consensus Aug 2, 2018
@xla xla modified the milestones: post-launch, launch Aug 2, 2018
@xla xla added the C:p2p Component: P2P pkg label Aug 2, 2018
@ebuchman
Copy link
Contributor

ebuchman commented Dec 4, 2018

closing for #2871

@ebuchman ebuchman closed this as completed Dec 4, 2018
firelizzard18 pushed a commit to AccumulateNetwork/tendermint that referenced this issue Feb 1, 2024
@andynog
docs: v1 - diataxis framework (tendermint#2105)
635d0b5 
close: tendermint#1613 

New structure for documentation using the [diataxis
framework](https://diataxis.fr). Created landing pages for the major
sections and re-organized the existing content into one of the 4 topics
of the diataxis framework (tutorials, how-to guides, technical reference
and explanation)


#### PR checklist

- [ ] Tests written/updated
- [ ] Changelog entry added in `.changelog` (we use
[unclog](https://github.com/informalsystems/unclog) to manage our
changelog)
- [X] Updated relevant documentation (`docs/` or `spec/`) and code
comments
- [ ] Title follows the [Conventional
Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C:consensus Component: Consensus C:p2p Component: P2P pkg
Projects
None yet
Milestone
Wishlist
Development

No branches or pull requests
3 participants
@xla @melekes @ebuchman