Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial setup for tensorflow subsite #486

Merged
merged 6 commits into from
Sep 18, 2019

Conversation

seanpmorgan
Copy link
Member

Starting a PR to close #226

@seanpmorgan seanpmorgan added documentation wip Work in-progress labels Sep 9, 2019
@seanpmorgan seanpmorgan requested a review from a team as a code owner September 9, 2019 00:51
Copy link
Member Author

@seanpmorgan seanpmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's difficult to check that these links are working correctly... Is it possible for the Docs team to test this PR or show us how to do that as a webpage?

Also, I didn't immediately see why overview.md and bar_guide.md are part of the template directory. Are these required?

docs/_book.yaml Outdated Show resolved Hide resolved
docs/_book.yaml Show resolved Hide resolved
docs/_index.yaml Show resolved Hide resolved
@seanpmorgan
Copy link
Member Author

Granted the docs team write permission as well.

@seanpmorgan seanpmorgan changed the title [WIP] Initial setup for tensorflow subsite Initial setup for tensorflow subsite Sep 10, 2019
@seanpmorgan
Copy link
Member Author

@lamberta @MarkDaoust changes made, thanks! What would be the path forward for testing this?

@lamberta
Copy link
Member

Great, thanks.
As far as testing notebooks, @yashk2810 has some CI set up in the tensorflow/docs repo. Not sure of the plan to extend that to other repos, but would be cool.
As far as full staging and previews, I don't think that's possible with our internal site infra. But if it works in the GitHub Markdown previewer and in Colab, then it should render fine on tensorflow.org. But if there's a launch or something, you can ping me (or someone) to stage internally and double check things.

CONTRIBUTING.md Outdated Show resolved Hide resolved
docs/_book.yaml Outdated Show resolved Hide resolved
- title: Triplet loss
path: /addons/tutorials/losses_triplet
- title: Image Ops
path: /addons/tutorials/image_ops
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lamberta So this part I'm still unclear on. Where does the directory "addons" come from? Is it just the repository name?

Does it need to be addons/docs/tutorials/*?

Copy link
Member

@MarkDaoust MarkDaoust Sep 10, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"/addons/tutorials/losses_triplet" is correct.

The workflow is "take a directory and put it on the site". Addons is just the name for this directory on the site.

So we'll set up the tools to take "https://github.com/tensorflow/addons/tree/master/docs" and put it on the site as "tensorflow.org/addons".

So two things to remember about links for that:

  1. Use relative links when linking between files within the directory (so users keep their github/colab/tensorflow.org context). Use full URLs if you need to link to something outside of the directory. Never use absolute path links.

  2. In notebooks and markdown tfa.thing will be auto-linked to the appropriate api-page, if it exists.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great thanks. So just to be clear will the utilized directory always come from master branch? At the moment we only generate docs for our release branches, but that'd probably require you pulling down a new directory for each release.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MarkDaoust @lamberta Friendly bump on this question and then we can look to merge this. Are we required to have the latest releases API docs on our master branch?

Copy link
Member

@MarkDaoust MarkDaoust Sep 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we required to have the latest releases API docs on our master branch?

No, we've simplified the setup. There is now no requirement to have api_docs in you repo at all. When we generate the site, we'll run your build_docs.py script against your latest pip package, to generate the api_docs pages.

So just to be clear will the utilized directory always come from master branch?

Yes. While api reference material is generated from your pip package, we pull the rest of the docs from master so that doc-fixes don't need to wait for a release.

The one caution there is that notebooks demonstrating features for a future release need to be sure to pip install an appropriate nightly or preview package, but if you're test running things in colab, for example, that should be easy to remember.

@yashk2810
Copy link
Member

yashk2810 commented Sep 12, 2019

As far as testing notebooks, @yashk2810 has some CI set up in the tensorflow/docs

Since a subsite is being created for addons, the notebooks will automatically get tested with the pipeline. If something fails, we will send an email to the addons team about the failure.

But there are a few things to keep in mind.

  1. We test with TF2 and python3 by default. There are other options but it's not enabled by default.
  2. Please follow the template
    https://github.com/tensorflow/docs/blob/master/tools/templates/notebook.ipynb to write the notebooks if it's not being written in this format.

Can you add the team's email where we can send the emails about failures?

@facaiy
Copy link
Member

facaiy commented Sep 15, 2019

@yashk2810 please send failure to addons-testing@tensorflow.org , thanks, Yash!

  1. We test with TF2 and python3 by default.

I'm fine, what do you think, Sean?

  1. Please follow the template

Will do, thanks

@facaiy
Copy link
Member

facaiy commented Sep 15, 2019

One more question, can we test notebook for master branch (I mean, tfa-nightly version)?

@yashk2810
Copy link
Member

I mean, tfa-nightly

Yes, the infra will install whatever version you install in the notebook.

@seanpmorgan
Copy link
Member Author

@yashk2810 please send failure to addons-testing@tensorflow.org , thanks, Yash!

  1. We test with TF2 and python3 by default.

I'm fine, what do you think, Sean?

  1. Please follow the template

Will do, thanks

Yes I agree this sounds good to me.

Copy link
Member

@MarkDaoust MarkDaoust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@seanpmorgan seanpmorgan removed the wip Work in-progress label Sep 18, 2019
@seanpmorgan seanpmorgan merged commit 849312a into tensorflow:master Sep 18, 2019
@seanpmorgan seanpmorgan deleted the doc-make-subsite branch September 18, 2019 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link API docs with with tensorflow.org
7 participants