-
Notifications
You must be signed in to change notification settings - Fork 610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial setup for tensorflow subsite #486
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's difficult to check that these links are working correctly... Is it possible for the Docs team to test this PR or show us how to do that as a webpage?
Also, I didn't immediately see why overview.md
and bar_guide.md
are part of the template directory. Are these required?
Granted the docs team write permission as well. |
@lamberta @MarkDaoust changes made, thanks! What would be the path forward for testing this? |
Great, thanks. |
- title: Triplet loss | ||
path: /addons/tutorials/losses_triplet | ||
- title: Image Ops | ||
path: /addons/tutorials/image_ops |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lamberta So this part I'm still unclear on. Where does the directory "addons" come from? Is it just the repository name?
Does it need to be addons/docs/tutorials/*
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"/addons/tutorials/losses_triplet" is correct.
The workflow is "take a directory and put it on the site". Addons is just the name for this directory on the site.
So we'll set up the tools to take "https://github.com/tensorflow/addons/tree/master/docs" and put it on the site as "tensorflow.org/addons".
So two things to remember about links for that:
-
Use relative links when linking between files within the directory (so users keep their github/colab/tensorflow.org context). Use full URLs if you need to link to something outside of the directory. Never use absolute path links.
-
In notebooks and markdown
tfa.thing
will be auto-linked to the appropriate api-page, if it exists.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great thanks. So just to be clear will the utilized directory always come from master
branch? At the moment we only generate docs for our release branches, but that'd probably require you pulling down a new directory for each release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MarkDaoust @lamberta Friendly bump on this question and then we can look to merge this. Are we required to have the latest releases API docs on our master branch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we required to have the latest releases API docs on our master branch?
No, we've simplified the setup. There is now no requirement to have api_docs in you repo at all. When we generate the site, we'll run your build_docs.py
script against your latest pip package, to generate the api_docs
pages.
So just to be clear will the utilized directory always come from master branch?
Yes. While api reference material is generated from your pip package, we pull the rest of the docs from master so that doc-fixes don't need to wait for a release.
The one caution there is that notebooks demonstrating features for a future release need to be sure to pip install
an appropriate nightly or preview package, but if you're test running things in colab, for example, that should be easy to remember.
Since a subsite is being created for addons, the notebooks will automatically get tested with the pipeline. If something fails, we will send an email to the addons team about the failure. But there are a few things to keep in mind.
Can you add the team's email where we can send the emails about failures? |
@yashk2810 please send failure to addons-testing@tensorflow.org , thanks, Yash!
I'm fine, what do you think, Sean?
Will do, thanks |
One more question, can we test notebook for master branch (I mean, tfa-nightly version)? |
Yes, the infra will install whatever version you install in the notebook. |
Yes I agree this sounds good to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Starting a PR to close #226