Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed errors - converted train_features and test_features to tensor, … #2295

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

gitshiva
Copy link

@gitshiva gitshiva commented Feb 13, 2024

…then updated Horsepower references to specific columns in array, otherwise this nb was failing due to data type mismatches

closes: #2313

…then updated Horsepower references to specific columns in array, otherwise this nb was failing due to data type mismatches
@gitshiva gitshiva requested a review from a team as a code owner February 13, 2024 22:58
Copy link

Preview

Preview and run these notebook edits with Google Colab: Rendered notebook diffs available on ReviewNB.com.

Format and style

Use the TensorFlow docs notebook tools to format for consistent source diffs and lint for style:
$ python3 -m pip install -U --user git+https://github.com/tensorflow/docs

$ python3 -m tensorflow_docs.tools.nbfmt notebook.ipynb
$ python3 -m tensorflow_docs.tools.nblint --arg=repo:tensorflow/docs notebook.ipynb
If commits are added to the pull request, synchronize your local branch: git pull origin master

Generate just one seed, rather than generating two seeds and then tak…
Copy link
Contributor

@8bitmp3 8bitmp3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@8bitmp3 8bitmp3 added the review in progress Someone is actively reviewing this PR label Feb 24, 2024
@8bitmp3 8bitmp3 assigned MarkDaoust and unassigned MarkDaoust Aug 15, 2024
@MarkDaoust
Copy link
Member

Hi, thanks for pointing this out and taking the time to send a PR.

I always prefer referencing columns by name instead of index, how about we do this:

gitshiva#2

@8bitmp3 8bitmp3 added the awaiting-contributor-response Indicates a question, draft, or work-in-progress label Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-contributor-response Indicates a question, draft, or work-in-progress review in progress Someone is actively reviewing this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants