-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added processing_census example notebook #591
Conversation
Check out this pull request on You'll be able to see Jupyter notebook diff and discuss changes. Powered by ReviewNB. |
Looks good! |
@MarkDaoust @lamberta I think it would make sense to have a link to pointing to this notebook from tensorflow.org/io. Do you know which file in docs needs to be updated? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @vlasenkoalexey,
We just got TensorFlow I/O setup on tensorflow.org.
The tensorflow.org pipeline is setup to handle notebooks. We can add a link to this, by adding the following to the docs/tutorials/_toc.yaml
- heading: "Tutorials"
- title: "Bigquery"
path: https://github.com/tensorflow/io/blob/master/tensorflow_io/bigquery/processing_census_example.ipynb
status: external
But, would it be better if we stuck this in docs/tutorials
directory, then we could publish it directly to the site?
If you do move it, please rename to "bigquery.ipynb" or something like that. And add the following entries to the _toc.yaml:
- heading: "Tutorials"
- title: "Bigquery"
path: /io/tutorials/bigquery
If you do the above, this will also be published as tensorflow.org/io/tutorials/bigquery
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved to docs/tutorial, and used format similar to TF template.
@MarkDaoust, applied changes, could you take another look |
@vlasenkoalexey Looks like there is a merge conflict, can you try to rebase? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I resolved that conflict.
But it looks like we don't have a good way to execute this to generate the site because of the required auth.
@vlasenkoalexey would it be possible to re-save the notebook with the output included so people can see the expected result?
@MarkDaoust, resaved notebook with outputs |
@MarkDaoust @lamberta to take a look to see if all the issues have been resolved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments. Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
* added processing_census example notebook * updated comments for user to set PROJECT_ID * added open in colab button * added dummy bigquery notebook from template * moved bigquery sample to docs/tutorials, addressed PR feedback * removed empty cells * fixed links * resaved bigquery.ipynb with outputs * addressed feedback from @lamberta
@sshrdp FYI