-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge Beholder into TensorBoard #613
Conversation
I'll take a look at fixing the paths tomorrow. |
Thank you Chris. We have two options:
|
The paths look good, but my tests fail (likely because I'm expecting a certain directory to already exist, I'm thinking). I don't have much free time nowadays - I'm thinking I'll just remove the tests for now (clearly the best solution when your tests fail haha). |
@jart The copy-pasted ffmpeg stuff is an issue still, right? |
Yes. Is there any chance you could just whip up a quick non-generalized private function to do what it's doing, so that file can be removed? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you so much for this amazing contribution!
:) Woo hoo! You're welcome. May tons of people learn and benefit from it. |
I know our lab will! I'm gonna use this as soon as it's in the regular pip package. Any idea when (or with which release) that will be? |
Beholder will most likely be released in TensorBoard 0.5 alongside TensorFlow 1.5. My best guess for when that would happen is January. I don't expect you to wait that long. So I just registered tb-nightly which will be tf-nightly's doppelganger. Once I'm done putting some polish on Chris' amazing work, I'll write a cron script to update that package, so you can start using it right away (without having to build from source.) cc: @gunan |
Sounds amazing, thank you!! |
@jart recommended just copying the files over at first without integrating things, so here are the copies. :)