Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apply bip44 luna coin type #178

Merged
merged 1 commit into from
Jun 19, 2019
Merged

apply bip44 luna coin type #178

merged 1 commit into from
Jun 19, 2019

Conversation

yun-yeo
Copy link
Contributor

@yun-yeo yun-yeo commented Jun 17, 2019 •
edited by hanjukim
Loading

** Summary of changes **

change bip44 coinType to 330(Luna) from 118(Atom)

** Report of required housekeeping **

  • Github issue OR spec proposal link
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added a relevant changelog entry: clog add [section] [stanza] [message]

======

** (FOR ADMIN) Before merging **

  • Added appropriate labels to PR
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)
  • Confirm added tests are consistent with the intended behavior of changes
  • Ensure all tests pass

@hanjukim hanjukim added client rest / cli code improvements daemon daemon updates labels Jun 19, 2019
@hanjukim hanjukim merged commit 23fdd5c into develop Jun 19, 2019
@yun-yeo yun-yeo deleted the feature/bip44-luna-coin-type branch June 21, 2019 06:06
@yun-yeo yun-yeo mentioned this pull request Jun 21, 2019
Merged
8 tasks
@sriney-staked sriney-staked mentioned this pull request Jun 24, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanjukim hanjukim hanjukim approved these changes

Assignees
No one assigned
Labels
client rest / cli code improvements daemon daemon updates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yun-yeo @hanjukim