Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/ Lazy Vesting Schedule #183

Merged
merged 17 commits into from
Jun 21, 2019
Merged

Feature/ Lazy Vesting Schedule #183

merged 17 commits into from
Jun 21, 2019

Conversation

yun-yeo
Copy link
Contributor

@yun-yeo yun-yeo commented Jun 20, 2019

** Summary of changes **

Apply lazy vesting schedule to all account at 230000 height
(Estimated: Sun Jun 23 2019 00:50:00 GMT+0000 (UTC))

oracle param update

OracleRewardBand: 1% => 2%

market param update

DailyLunaDeltaCap: 0.5% => 0.1%

Solve #180, #181

** Report of required housekeeping **

  • Github issue OR spec proposal link
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added a relevant changelog entry: clog add [section] [stanza] [message]

======

** (FOR ADMIN) Before merging **

  • Added appropriate labels to PR
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)
  • Confirm added tests are consistent with the intended behavior of changes
  • Ensure all tests pass

@yun-yeo yun-yeo requested review from hanjukim and dokwon June 20, 2019 09:51
@hanjukim hanjukim added daemon daemon updates enhancement New feature or request labels Jun 20, 2019
update/end_blocker.go Outdated Show resolved Hide resolved
Copy link
Contributor

@dokwon dokwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing significant, we may want to smooth out vesting rule changes for improved readability

@dokwon
Copy link
Contributor

dokwon commented Jun 20, 2019

@YunSuk-Yeo does this pass make lint for you?

@hanjukim
Copy link
Contributor

@dokwon make lint from mine

go get github.com/rakyll/statik
go get github.com/golangci/golangci-lint/cmd/golangci-lint
go: finding github.com/golangci/golangci-lint/cmd/golangci-lint latest
go: finding github.com/golangci/golangci-lint/cmd latest
--> Running lint...
golangci-lint run
go vet -composites=false -tests=false ./...
find . -name '*.go' -type f -not -path "./vendor*" -not -path "*.git*" | xargs gofmt -d -s
go mod verify
all modules verified

@yun-yeo yun-yeo requested a review from dokwon June 20, 2019 15:57
Copy link
Contributor

@dokwon dokwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dokwon dokwon merged commit 4893ffa into develop Jun 21, 2019
@yun-yeo yun-yeo mentioned this pull request Jun 21, 2019
8 tasks
@yun-yeo yun-yeo deleted the feature/delay-vesting branch June 25, 2019 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
daemon daemon updates enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants