Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] CosmosSDK v0.38 #323

Merged
merged 13 commits into from
Jun 11, 2020
Merged

[Feature] CosmosSDK v0.38 #323

merged 13 commits into from
Jun 11, 2020

Conversation

yun-yeo
Copy link
Contributor

@yun-yeo yun-yeo commented Feb 10, 2020

Summary of changes

  • Bump sdk version to v0.38.3

Change Logs

v0.38.0, v0.38.1, v0.38.2 ,v0.38.3

Report of required housekeeping

  • Github issue OR spec proposal link
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added a relevant changelog entry: clog add [section] [stanza] [message]

(FOR ADMIN) Before merging

  • Added appropriate labels to PR
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)
  • Confirm added tests are consistent with the intended behavior of changes
  • Ensure all tests pass

@yun-yeo yun-yeo added devops installation, deployment and node management daemon daemon updates WIP work in progress devtools devtool related update labels Feb 10, 2020
@yun-yeo yun-yeo changed the title Feature/sdk v0.38 [WIP] Feature/sdk v0.38 Feb 10, 2020
@codecov
Copy link

codecov bot commented Feb 10, 2020

Codecov Report

Merging #323 into develop will decrease coverage by 1.91%.
The diff coverage is 59.04%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #323      +/-   ##
===========================================
- Coverage    71.38%   69.47%   -1.92%     
===========================================
  Files           75       70       -5     
  Lines         3649     3554      -95     
===========================================
- Hits          2605     2469     -136     
- Misses         899      948      +49     
+ Partials       145      137       -8     
Impacted Files Coverage Δ
app/export.go 28.82% <0.00%> (-1.18%) ⬇️
x/market/internal/keeper/alias_functions.go 0.00% <0.00%> (ø)
x/market/internal/keeper/params.go 100.00% <ø> (ø)
x/market/internal/types/tobin_tax.go 0.00% <0.00%> (ø)
x/market/module.go 0.00% <0.00%> (ø)
x/oracle/internal/keeper/params.go 37.93% <ø> (-4.01%) ⬇️
x/oracle/internal/types/denom.go 0.00% <0.00%> (ø)
x/oracle/module.go 0.00% <0.00%> (ø)
x/treasury/internal/keeper/alias_functions.go 0.00% <0.00%> (ø)
x/treasury/internal/keeper/params.go 53.84% <ø> (-3.30%) ⬇️
... and 47 more

@dokwon
Copy link
Contributor

dokwon commented Mar 24, 2020

@YunSuk-Yeo please resolve conflicts. Could you also add a link to the SDK changelog in the PR body as to what changes took place?

@yun-yeo yun-yeo self-assigned this Mar 25, 2020
@yun-yeo yun-yeo changed the title [WIP] Feature/sdk v0.38 Feature/sdk v0.38 Apr 21, 2020
@yun-yeo yun-yeo removed the WIP work in progress label Apr 21, 2020
@yun-yeo yun-yeo requested a review from dokwon April 21, 2020 09:12
@yun-yeo
Copy link
Contributor Author

yun-yeo commented May 25, 2020

@dokwon conflict resolved and added change logs link to PR body

@yun-yeo yun-yeo mentioned this pull request May 25, 2020
14 tasks
@yun-yeo yun-yeo mentioned this pull request Jun 2, 2020
8 tasks
@hanjukim hanjukim changed the title Feature/sdk v0.38 [Feature] CosmosSDK v0.38 Jun 8, 2020
@hanjukim hanjukim self-requested a review June 11, 2020 08:23
@hanjukim hanjukim merged commit a14ca8e into develop Jun 11, 2020
@hanjukim hanjukim deleted the feature/sdk-v0.38 branch June 11, 2020 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
daemon daemon updates devops installation, deployment and node management devtools devtool related update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants