Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump cosmos-sdk to v0.44.0 #551

Merged
merged 10 commits into from
Sep 20, 2021
Merged

bump cosmos-sdk to v0.44.0 #551

merged 10 commits into from
Sep 20, 2021

Conversation

yun-yeo
Copy link
Contributor

@yun-yeo yun-yeo commented Sep 2, 2021

Summary of changes

Client Breaking Changes

Cosmos SDK stopped supporting legacy amino style transaction, which means /txs endpoint will not be working anymore. However there are so many entities who are still using legacy style transaction building method, so we think
it is necessary to give enough time to prepare for this kind of updates.

To avoid sudden big changes, we introduce our custom /txs endpoint.

  • This custom endpoints internally convert the legacy tx into the new proto style tx with some additional inputs.
  • Moreover it also give you some space to use new features like fee granter and timeout height.

Our custom /txs endpoint receive more optional inputs as follow

{
  "tx": StdTx,
  "mode": "block" | "sync" | "async",
   // Below fields are newly introduced optional arguments.
   // To convert legacy tx to new proto tx, we need each signer's sequence number. 
   // If this field is not given, we fetch the sequence from the chain state. Normal 
   // users can skip this field as well, but the users who are sending faster than block 
   // time need to provide this field.
  "sequences": ["1", "2"],
  "fee_granter": ""
}

Report of required housekeeping

  • Github issue OR spec proposal link
  • Wrote tests
  • Updated API documentation (client/lcd/swagger-ui/swagger.yaml)
  • Added a relevant changelog entry: clog add [section] [stanza] [message]

(FOR ADMIN) Before merging

  • Added appropriate labels to PR
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)
  • Confirm added tests are consistent with the intended behavior of changes
  • Ensure all tests pass

@yun-yeo yun-yeo added the must Mustfix for target release. label Sep 2, 2021
@yun-yeo yun-yeo self-assigned this Sep 2, 2021
@codecov
Copy link

codecov bot commented Sep 2, 2021

Codecov Report

Merging #551 (b28cae3) into main (ea2849c) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #551   +/-   ##
=======================================
  Coverage   44.88%   44.88%           
=======================================
  Files         118      118           
  Lines        6829     6829           
=======================================
  Hits         3065     3065           
  Misses       3527     3527           
  Partials      237      237           
Impacted Files Coverage Δ
app/app.go 0.67% <0.00%> (ø)

@kjessec kjessec mentioned this pull request Sep 6, 2021
11 tasks
@dimiandre
Copy link

dimiandre commented Sep 14, 2021

The /txs endpoint was removed from Cosmos SDK because of a security vulnerability, have you check to not be affected?

cosmos/cosmos-sdk#10029

@yun-yeo
Copy link
Contributor Author

yun-yeo commented Sep 17, 2021

The /txs endpoint was removed from Cosmos SDK because of a security vulnerability, have you check to not be affected?

cosmos/cosmos-sdk#10029

Yea we applied some fix to prevent breaking backward compatibility.

@yun-yeo yun-yeo merged commit 77caae9 into main Sep 20, 2021
@yun-yeo yun-yeo deleted the bump/sdk branch September 20, 2021 03:12
reuvenpo referenced this pull request in scrtlabs/cosmos-sdk Oct 7, 2021
Cashmaney referenced this pull request in scrtlabs/cosmos-sdk Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
must Mustfix for target release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants