Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] skip get byte when exporting not migrated code #607

Merged
merged 1 commit into from
Nov 22, 2021

Conversation

yun-yeo
Copy link
Contributor

@yun-yeo yun-yeo commented Nov 16, 2021

Summary of changes

close #606

Report of required housekeeping

  • Github issue OR spec proposal link
  • Wrote tests
  • Updated API documentation (client/lcd/swagger-ui/swagger.yaml)
  • Added a relevant changelog entry: clog add [section] [stanza] [message]

(FOR ADMIN) Before merging

  • Added appropriate labels to PR
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)
  • Confirm added tests are consistent with the intended behavior of changes
  • Ensure all tests pass

@yun-yeo yun-yeo self-assigned this Nov 16, 2021
@codecov
Copy link

codecov bot commented Nov 16, 2021

Codecov Report

Merging #607 (d9c6696) into main (19b75bf) will increase coverage by 0.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #607      +/-   ##
==========================================
+ Coverage   44.69%   44.71%   +0.01%     
==========================================
  Files         120      120              
  Lines        6967     6969       +2     
==========================================
+ Hits         3114     3116       +2     
  Misses       3614     3614              
  Partials      239      239              
Impacted Files Coverage Δ
x/wasm/genesis.go 68.00% <66.66%> (+1.33%) ⬆️

@yun-yeo yun-yeo requested a review from Vritra4 November 22, 2021 00:08
@yun-yeo yun-yeo merged commit 746a15f into main Nov 22, 2021
@yun-yeo yun-yeo deleted the bugfix/wasm-export branch December 6, 2021 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Panic in terrad export
2 participants