Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit fix #670

Merged
merged 7 commits into from
Feb 3, 2022
Merged

Audit fix #670

merged 7 commits into from
Feb 3, 2022

Conversation

yun-yeo
Copy link
Contributor

@yun-yeo yun-yeo commented Feb 1, 2022

Summary of changes

close #667

We will add more msg validate function to prevent overflow inputs.
but for now, we need to recover from overflow case

Report of required housekeeping

  • Github issue OR spec proposal link
  • Wrote tests
  • Updated API documentation (client/lcd/swagger-ui/swagger.yaml)
  • Added a relevant changelog entry: clog add [section] [stanza] [message]

(FOR ADMIN) Before merging

  • Added appropriate labels to PR
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)
  • Confirm added tests are consistent with the intended behavior of changes
  • Ensure all tests pass

@yun-yeo yun-yeo requested a review from Vritra4 February 1, 2022 05:12
@yun-yeo yun-yeo self-assigned this Feb 1, 2022
@codecov
Copy link

codecov bot commented Feb 1, 2022

Codecov Report

Merging #670 (ee60309) into main (0b3a306) will increase coverage by 0.40%.
The diff coverage is 91.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #670      +/-   ##
==========================================
+ Coverage   44.63%   45.03%   +0.40%     
==========================================
  Files         120      120              
  Lines        6999     7001       +2     
==========================================
+ Hits         3124     3153      +29     
+ Misses       3630     3601      -29     
- Partials      245      247       +2     
Impacted Files Coverage Δ
x/market/keeper/msg_server.go 0.00% <ø> (ø)
x/wasm/types/gas_meter.go 81.25% <90.47%> (+81.25%) ⬆️
x/oracle/types/ballot.go 66.17% <100.00%> (+1.56%) ⬆️

@yun-yeo yun-yeo merged commit 951fee0 into main Feb 3, 2022
@yun-yeo yun-yeo deleted the audit-fix branch February 3, 2022 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: x/oracle integer overflow
2 participants