Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make min spread to 100% to disable swap #760

Merged
merged 4 commits into from
May 13, 2022
Merged

Conversation

yun-yeo
Copy link
Contributor

@yun-yeo yun-yeo commented May 13, 2022

Summary of changes

Make minimum swap spread one to disable swap operation

Disable IBC channels for Osmosis, Crescent, Juno

Report of required housekeeping

  • Github issue OR spec proposal link
  • Wrote tests
  • Updated API documentation (client/lcd/swagger-ui/swagger.yaml)
  • Added a relevant changelog entry: clog add [section] [stanza] [message]

(FOR ADMIN) Before merging

  • Added appropriate labels to PR
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)
  • Confirm added tests are consistent with the intended behavior of changes
  • Ensure all tests pass

hanjukim
hanjukim previously approved these changes May 13, 2022
@codecov
Copy link

codecov bot commented May 13, 2022

Codecov Report

Merging #760 (7b163cb) into main (25d6113) will decrease coverage by 0.21%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #760      +/-   ##
==========================================
- Coverage   64.83%   64.62%   -0.22%     
==========================================
  Files         100      100              
  Lines        4596     4611      +15     
==========================================
  Hits         2980     2980              
- Misses       1402     1417      +15     
  Partials      214      214              
Impacted Files Coverage Δ
app/app.go 0.65% <0.00%> (-0.03%) ⬇️
x/market/keeper/msg_server.go 0.00% <0.00%> (ø)

yun-yeo and others added 2 commits May 13, 2022 14:44
@yun-yeo yun-yeo merged commit 1302858 into main May 13, 2022
@yun-yeo yun-yeo deleted the feature/make-min-spread-to-one branch May 13, 2022 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants