Better customization through use of a specific stylesheet protocol

[grantjk]

Hi,
I just came across the lib recently and was playing around with customizing the colors a bit more. Because I like using Cocoapods, I like having the ability to customize the message views without directly altering the original libraries.

This pull request specifies a stylesheet protocol so anyone can pass in an object that conforms to the protocol and change the attributes they want. It also makes it really easy to subclass the default TWMessageBarStyleSheet and only override some of the properties. Trying to change the background color of only one of the message types is as easy as subclassing the TWMessageBarStyleSheet and just calling super for the non-modified types.

I'd be interested to hear what you think, I threw this together pretty quick this afternoon, but it appears to work for me.

I'd be happy to make more changes too.

• JG

[terryworona]

I was meaning to do something like this. To be honest, I have no idea why I architected the customization component (ie. stylesheet) the way I did; it's less than ideal.

I'll take a look at this PR this week and likely pull it in.

[grantjk]

Great! Let me know if you see something to change. I'm happy to figure something out.

On Dec 16, 2013, at 5:02 PM, terryworona notifications@github.com wrote:

I was meaning to do something like this. To be honest, I have no idea why I architected the customization component (ie. stylesheet) the way I did; it's less than ideal.

I'll take a look at this PR this week and likely pull it in.

—
Reply to this email directly or view it on GitHub.

[terryworona]

Alright I merged it all in. Changed just a few things and created a demo style sheet. This provides a much better solution going forward for adding further customization options.

[grantjk]

Great!
Only thing I can see is that it might be a good idea to expose the interface for TWDefaultMessageBarStyleSheet in the header file so that basic customization like the following is still possible:

@interface HMSCMessageBarStyleSheet : TWDefaultMessageBarStyleSheet

@end

@implementation HMSCMessageBarStyleSheet

- (UIColor *)backgroundColorForMessageType:(TWMessageBarMessageType)type
{
    switch (type) {
        case TWMessageBarMessageTypeError:
            return [UIColor redColor];
            break;
        case TWMessageBarMessageTypeInfo:
        case TWMessageBarMessageTypeSuccess:
            return [super backgroundColorForMessageType:type];
        default:
            break;
    }
}

@end