-
-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reintroducing Papercut container modual #1268
Open
TechLiam
wants to merge
14
commits into
testcontainers:develop
Choose a base branch
from
TechLiam:feature/reintroduced-papercut
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Reintroducing Papercut container modual #1268
TechLiam
wants to merge
14
commits into
testcontainers:develop
from
TechLiam:feature/reintroduced-papercut
+347
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…endpoint for Papercut WebUI Service
✅ Deploy Preview for testcontainers-dotnet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…ntainers all at once fighting over resources reduction
…nto feature/reintroduced-papercut # Conflicts: # build.cake
…nto feature/reintroduced-papercut
… pipelines though so we don't destroy developer boxes with images we didn't create
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Added a wait strategy using HTTP request is succeeded for the health endpoint for Papercut WebUI Service.
This should stop the failing on the pipeline raised here #1265
Why is it important?
The wait strategy allows the container to be ready for testing and usage when starting up especially in a very busy environment
Related issues
None
How to test this PR
Tests pass now when running dotnet cake
Follow-ups
Hopefully, there is enough here to stop the issues @HofmeisterAn was having when doing other modules