Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#650): Update SharpZipLib to version 1.4.1 to prevent a deadlock in the Docker container image build #671

Merged
merged 3 commits into from
Nov 12, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
### Fixed

- 610 Trim traling slashes in Dockerfile directory path (otherwise, it cuts the first character of the relative path), Normalize paths to forward slashes
- 650 Update SharpZipLib to version 1.4.1 to prevent a deadlock in the Docker container image build

## [2.2.0]

Expand Down
5 changes: 2 additions & 3 deletions Packages.props
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,12 @@
<GlobalPackageReference Include="Microsoft.CodeAnalysis.NetAnalyzers" Version="6.0.0" />
<GlobalPackageReference Include="Microsoft.SourceLink.GitHub" Version="1.1.1" />
<GlobalPackageReference Include="StyleCop.Analyzers" Version="1.2.0-beta.435" />
<PackageReference Update="JetBrains.Annotations" Version="2022.1.0" PrivateAssets="all" />
<PackageReference Update="JetBrains.Annotations" Version="2022.3.1" PrivateAssets="all" />
<PackageReference Update="Docker.DotNet" Version="3.125.12" />
<PackageReference Update="Docker.DotNet.X509" Version="3.125.12" />
<PackageReference Update="Microsoft.Bcl.AsyncInterfaces" Version="1.1.1" />
<PackageReference Update="Microsoft.Extensions.Logging.Abstractions" Version="3.1.26" />
<PackageReference Update="Portable.BouncyCastle" Version="1.9.0" />
<PackageReference Update="SharpZipLib" Version="1.4.0" />
<PackageReference Update="SharpZipLib" Version="1.4.1" />
<PackageReference Update="System.Text.Json" Version="4.7.2" />
<!-- Unit and integration test dependencies: -->
<PackageReference Update="Microsoft.NET.Test.Sdk" Version="17.3.2" />
Expand Down
2 changes: 0 additions & 2 deletions examples/WeatherForecast/Directory.Build.props
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
<?xml version="1.0" encoding="utf-8"?>
<Project>
<PropertyGroup>
<!-- https://github.com/dotnet/sdk/issues/17645 -->
<UseCommonOutputDirectory>true</UseCommonOutputDirectory>
<SolutionDir Condition=" '$(SolutionDir)' == '' ">$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildProjectDirectory), WeatherForecast.sln))/</SolutionDir>
<BuildDir>$(SolutionDir)build/</BuildDir>
<BaseIntermediateOutputPath>$(BuildDir)obj/$(MSBuildProjectName)</BaseIntermediateOutputPath>
Expand Down
2 changes: 1 addition & 1 deletion examples/WeatherForecast/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ COPY . .

RUN dotnet restore $CSPROJ_FILE_PATH

RUN dotnet publish $CSPROJ_FILE_PATH --configuration Release --output out
RUN dotnet publish $CSPROJ_FILE_PATH --configuration Release --framework net6.0 --output out

FROM mcr.microsoft.com/dotnet/aspnet:6.0
ARG RESOURCE_REAPER_SESSION_ID="00000000-0000-0000-0000-000000000000"
Expand Down
2 changes: 1 addition & 1 deletion examples/WeatherForecast/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ This example builds and ships a Blazor application in a Docker image build, runs

```console
git lfs version
git clone git@github.com:testcontainers/testcontainers-dotnet.git
git clone --branch develop git@github.com:testcontainers/testcontainers-dotnet.git
cd ./testcontainers-dotnet/examples/WeatherForecast/
dotnet build WeatherForecast.sln
dotnet test WeatherForecast.sln
Expand Down
4 changes: 2 additions & 2 deletions examples/WeatherForecast/WeatherForecast.sln
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,9 @@ Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "WeatherForecast.Interactors
EndProject
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "WeatherForecast.Repositories", "src\WeatherForecast.Repositories\WeatherForecast.Repositories.csproj", "{B56FE398-0CD9-4747-9B58-812EE659A61A}"
EndProject
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "WeatherForecast.Test", "tests\WeatherForecast.Test\WeatherForecast.Test.csproj", "{B8C371A9-6B6C-4595-9B5B-88071D6F3A71}"
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "WeatherForecast.Tests", "tests\WeatherForecast.Tests\WeatherForecast.Tests.csproj", "{B8C371A9-6B6C-4595-9B5B-88071D6F3A71}"
EndProject
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "WeatherForecast.InProcess.Test", "tests\WeatherForecast.InProcess.Test\WeatherForecast.InProcess.Test.csproj", "{2D4474DB-9E16-4931-ADD0-569306C1C5AE}"
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "WeatherForecast.InProcess.Tests", "tests\WeatherForecast.InProcess.Tests\WeatherForecast.InProcess.Tests.csproj", "{2D4474DB-9E16-4931-ADD0-569306C1C5AE}"
EndProject
Global
GlobalSection(SolutionConfigurationPlatforms) = preSolution
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
</ItemGroup>
<ItemGroup>
<ProjectReference Include="../../../../src/Testcontainers/Testcontainers.csproj"/>
<ProjectReference Include="$(SolutionDir)src/WeatherForecast/WeatherForecast.csproj"/>
<!-- https://github.com/dotnet/sdk/issues/17645 -->
<ProjectReference Include="$(SolutionDir)src/WeatherForecast/WeatherForecast.csproj" Private="False"/>
</ItemGroup>
</Project>
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
using WeatherForecast.Repositories;
using Xunit;

namespace WeatherForecast.InProcess.Test;
namespace WeatherForecast.InProcess.Tests;

[UsedImplicitly]
public sealed class WeatherForecastTest : IAsyncLifetime
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
using JetBrains.Annotations;
using Xunit;

namespace WeatherForecast.Test;
namespace WeatherForecast.Tests;

[UsedImplicitly]
public sealed class WeatherForecastContainer : HttpClient, IAsyncLifetime
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
using JetBrains.Annotations;
using Xunit;

namespace WeatherForecast.Test;
namespace WeatherForecast.Tests;

[UsedImplicitly]
public sealed class WeatherForecastImage : IDockerImage, IAsyncLifetime
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
using WeatherForecast.Entities;
using Xunit;

namespace WeatherForecast.Test;
namespace WeatherForecast.Tests;

public static class WeatherForecastTest
{
Expand Down
1 change: 0 additions & 1 deletion src/Testcontainers/Testcontainers.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
<PackageReference Include="JetBrains.Annotations" />
<PackageReference Include="Docker.DotNet" />
<PackageReference Include="Docker.DotNet.X509" />
<PackageReference Include="Microsoft.Bcl.AsyncInterfaces" />
<PackageReference Include="Microsoft.Extensions.Logging.Abstractions" />
<PackageReference Include="Portable.BouncyCastle" />
<PackageReference Include="SharpZipLib" />
Expand Down