chore: run make lint on new modules (#2122)

* chore: run make lint for new modules

* chore: add readability in the generate function

* chore: modify output message to include make lint

modulegen/internal/main.go

@@ -34,17 +34,22 @@ func Generate(moduleVar context.TestcontainersModuleVar, isModule bool) error {
 	}
 
 	cmdDir := filepath.Join(ctx.RootDir, tcModule.ParentDir(), tcModule.Lower())
-	err = tools.GoModTidy(cmdDir)
-	if err != nil {
-		return fmt.Errorf(">> error synchronizing the dependencies: %w", err)
+	lintCmds := []func(string) error{
+		tools.GoModTidy,
+		tools.GoVet,
+		tools.MakeLint,
 	}
-	err = tools.GoVet(cmdDir)
-	if err != nil {
-		return fmt.Errorf(">> error checking generated code: %w", err)
+
+	for _, lintCmd := range lintCmds {
+		err = lintCmd(cmdDir)
+		if err != nil {
+			return err
+		}
 	}
 
-	fmt.Println("Please go to", cmdDir, "directory to check the results, where 'go mod tidy' and 'go vet' was executed to synchronize the dependencies")
-	fmt.Println("Commit the modified files and submit a pull request to include them into the project")
+	fmt.Println("Please go to", cmdDir, "directory to check the results, where 'go mod tidy', 'go vet' and 'make lint' were executed.")
+	fmt.Println("🙏 Commit the modified files and submit a pull request to include them into the project.")
+	fmt.Println("Remember to run 'make lint' before submitting the pull request.")
 	fmt.Println("Thanks!")
 	return nil
 }

modulegen/internal/tools/exec.go

@@ -1,19 +1,39 @@
 package tools
 
 import (
+	"fmt"
 	"os/exec"
 )
 
 func GoModTidy(cmdDir string) error {
-	return runGoCommand(cmdDir, "mod", "tidy")
+	if err := runGoCommand(cmdDir, "mod", "tidy"); err != nil {
+		return fmt.Errorf(">> error synchronizing the dependencies: %w", err)
+	}
+	return nil
 }
 
 func GoVet(cmdDir string) error {
-	return runGoCommand(cmdDir, "vet", "./...")
+	if err := runGoCommand(cmdDir, "vet", "./..."); err != nil {
+		return fmt.Errorf(">> error checking generated code: %w", err)
+	}
+	return nil
+}
+
+func MakeLint(cmdDir string) error {
+	if err := runMakeCommand(cmdDir, "lint"); err != nil {
+		return fmt.Errorf(">> error synchronizing the dependencies: %w", err)
+	}
+	return nil
 }
 
 func runGoCommand(cmdDir string, args ...string) error {
 	cmd := exec.Command("go", args...)
 	cmd.Dir = cmdDir
 	return cmd.Run()
 }
+
+func runMakeCommand(cmdDir string, args ...string) error {
+	cmd := exec.Command("make", args...)
+	cmd.Dir = cmdDir
+	return cmd.Run()
+}