Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot modify Ryuk image #2045

Closed
mdelapenya opened this issue Dec 22, 2023 Discussed in #2044 · 0 comments · Fixed by #2046
Closed

Cannot modify Ryuk image #2045

mdelapenya opened this issue Dec 22, 2023 Discussed in #2044 · 0 comments · Fixed by #2046
Assignees
Labels
bug An issue with the library

Comments

@mdelapenya
Copy link
Collaborator

Discussed in #2044

Originally posted by lalloni December 22, 2023
I tried both mechanisms for overriding image names (TESTCONTAINERS_HUB_IMAGE_NAME_PREFIX env var and using an ImageSubstitutor implementation) to prefix the Ryuk image name with an internal registry URL. Both methods failed and were completely ignored for the Ryuk image. They worked for the other images we are running, though.

I think the issue is most likely caused by the fact that the default Ryuk image is defined as

ReaperDefaultImage = "docker.io/testcontainers/ryuk:0.5.1"

And that constant includes the docker.io/ string prefix, making it non-overridable (according to documentation).

How should we do this?

If the right way of fixing the issue is changing the default image name to the following, I would be happy to send a PR:

ReaperDefaultImage = "testcontainers/ryuk:0.5.1"
@mdelapenya mdelapenya added the bug An issue with the library label Dec 22, 2023
@mdelapenya mdelapenya self-assigned this Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue with the library
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant