fix: remove docker.io from Ryuk image name #2046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It will make it configurable with the TESTCONTAINERS_HUB_IMAGE_NAME_PREFIX env var or the hub.image.name.prefix property
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It removes the
docker.io/prefix from the default Ryuk image, to adhere to the docs in https://golang.testcontainers.org/features/image_name_substitution/#automatically-modifying-docker-hub-image-namesWhy is it important?
It will make Ryuk configurable with the
TESTCONTAINERS_HUB_IMAGE_NAME_PREFIXenv var or thehub.image.name.prefixproperty,allowing developers to put Ryuk on their own registries if/when needed.
Related issues
How to test this PR
Update the
~/.testcontainers.propertieswith:hub.image.name.prefix=registry.mycompany.com/mirrorThen run a test in the project: because the prefix points to a non-existent registry, the test will fail because Ryuk cannot be found,
meaning that the prefix was applied to Ryuk.