Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modulegen: create internal/module #1505

Merged
merged 1 commit into from
Aug 24, 2023
Merged

modulegen: create internal/module #1505

merged 1 commit into from
Aug 24, 2023

Conversation

mmorel-35
Copy link
Contributor

Refactor exec (go vet and go mod tidy) code in modulegen

@mmorel-35 mmorel-35 requested a review from a team as a code owner August 15, 2023 10:06
@netlify
Copy link

netlify bot commented Aug 15, 2023

Deploy Preview for testcontainers-go ready!

Name Link
🔨 Latest commit 3783934
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/64e70ab8d56f8c0008a58790
😎 Deploy Preview https://deploy-preview-1505--testcontainers-go.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mmorel-35 mmorel-35 marked this pull request as draft August 18, 2023 05:22
@mmorel-35 mmorel-35 changed the title modulegen: create pkg/module modulegen: create internal/module Aug 22, 2023
@mmorel-35 mmorel-35 marked this pull request as ready for review August 24, 2023 07:26
Copy link
Collaborator

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes regarding package name.

BTW I'm liking how you're setting up the layout for the module generation tool! Congrats!

modulegen/internal/module/exec.go Outdated Show resolved Hide resolved
modulegen/main.go Outdated Show resolved Hide resolved
modulegen/main.go Outdated Show resolved Hide resolved
modulegen/main.go Outdated Show resolved Hide resolved
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@sonarcloud
Copy link

sonarcloud bot commented Aug 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
6.7% 6.7% Duplication

Copy link
Collaborator

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mdelapenya mdelapenya merged commit 94c8cb6 into testcontainers:main Aug 24, 2023
117 checks passed
@mmorel-35 mmorel-35 deleted the modulegen/module branch August 24, 2023 08:52
@mdelapenya mdelapenya self-assigned this Aug 25, 2023
@mdelapenya mdelapenya added the chore Changes that do not impact the existing functionality label Aug 25, 2023
mdelapenya added a commit to igribkov/testcontainers-go that referenced this pull request Aug 28, 2023
* main: (26 commits)
  modulegen: create internal/make (testcontainers#1537)
  chore: fix workflow (testcontainers#1538)
  chore(deps): bump the all group in /examples/cockroachdb with 1 update (testcontainers#1522)
  chore(deps): bump the all group in /examples/bigtable with 1 update (testcontainers#1534)
  chore(deps): bump the all group in /modules/localstack with 4 updates (testcontainers#1535)
  chore(deps): bump the all group in /modules/k3s with 2 updates (testcontainers#1526)
  chore(deps): bump the all group in /examples/spanner with 2 updates (testcontainers#1532)
  chore(deps): bump the all group in /examples/firestore with 1 update (testcontainers#1523)
  chore(deps): bump the all group in /modules/redis with 1 update (testcontainers#1524)
  chore(deps): bump the all group in /modules/clickhouse with 1 update (testcontainers#1525)
  chore(deps): bump the all group in /examples/toxiproxy with 2 updates (testcontainers#1528)
  chore(deps): bump the all group in /examples/pubsub with 1 update (testcontainers#1531)
  chore(deps): bump the all group in /examples/datastore with 2 updates (testcontainers#1530)
  chore(deps): bump the all group in /modules/redpanda with 1 update (testcontainers#1527)
  chore: properly render mkdocs.yml (testcontainers#1521)
  modulegen: create internal/workflow (testcontainers#1520)
  modulegen: create internal/module (testcontainers#1505)
  modulegen: create internal/mkdocs (testcontainers#1504)
  fix: do not remove the file schema in docker.host property (testcontainers#1517)
  fix: reset config in tests (testcontainers#1516)
  ...
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Changes that do not impact the existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants