-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Improved Oracle DB module #363
Conversation
Signed-off-by: gvenzl <gerald.venzl@gmail.com>
Signed-off-by: gvenzl <gerald.venzl@gmail.com>
Signed-off-by: gvenzl <gerald.venzl@gmail.com>
Signed-off-by: gvenzl <gerald.venzl@gmail.com>
Signed-off-by: gvenzl <gerald.venzl@gmail.com>
Signed-off-by: gvenzl <gerald.venzl@gmail.com>
Signed-off-by: gvenzl <gerald.venzl@gmail.com>
Signed-off-by: gvenzl <gerald.venzl@gmail.com>
Signed-off-by: gvenzl <gerald.venzl@gmail.com>
and not dbname Signed-off-by: gvenzl <gerald.venzl@gmail.com>
Signed-off-by: gvenzl <gerald.venzl@gmail.com>
Signed-off-by: gvenzl <gerald.venzl@gmail.com>
Signed-off-by: gvenzl <gerald.venzl@gmail.com>
Signed-off-by: gvenzl <gerald.venzl@gmail.com>
Signed-off-by: gvenzl <gerald.venzl@gmail.com>
Looking at the failed job, I'm fairly certain that this was a strange, potentially race condition on that individual execution of the test. I have seen situations where Docker Hub refuses to have images pulled if the pull frequency is too high. My guess is that it will execute just fine and if not, it will be a clear indicator that there is something off with that particular test that needs fixing. |
Yes, looks like it. I've restarted the run. Would it be possible to improve timeout handling so the tests fail earlier? The current setup ran for a few hours before bailing: https://github.com/testcontainers/testcontainers-python/actions/runs/5237034596/jobs/9470709201?pr=363#step:7:291 |
Hey @tillahoffmann, Thanks a lot, it did go through this time! Happy to increase the timeout if you could point me in the right direction.
I suspect something went wrong under the covers with spinning up the container altogether, given the |
Hey @tillahoffmann, just wanted to check in on that one and see how you want to proceed. Thx, |
Signed-off-by: gvenzl <gerald.venzl@gmail.com>
Hey @tillahoffmann, I've cleared the merge conflict and pumped up the |
Signed-off-by: Gerald Venzl <gerald.venzl@gmail.com>
Signed-off-by: Gerald Venzl <gerald.venzl@gmail.com>
Signed-off-by: Gerald Venzl <gerald.venzl@gmail.com>
following! Is there any update on this? thanks! |
did some exploratory work here - main...alexanderankin:testcontainers-python:gvenzl_main |
the original pull request which was opened last june had a hidden feature, which was a merged PR, which was also separately merged into testcontainers-python. additionally, there are several commits dealing only with setup.py and other removed files, which made for an interesting rebase. lastly, i removed the option to start it with a random password as that is unusable (youd have to open the logs and get the password out of there. at any rate, the oracle module is up to date again! |
the original commits are here for reference - https://github.com/testcontainers/testcontainers-python/commits/gvenzl/oracle-free |
🤖 I have created a release *beep* *boop* --- ## [4.3.0](testcontainers-v4.2.0...testcontainers-v4.3.0) (2024-04-01) ### Features * **client:** Add custom User-Agent in Docker client as `tc-python/<version>` ([#507](#507)) ([dd55082](dd55082)) ### Bug Fixes * Add CassandraContainer ([#476](#476)) ([507e466](507e466)) * add chroma container ([#515](#515)) ([0729bf4](0729bf4)) * Add Weaviate module ([#492](#492)) ([90762e8](90762e8)) * **cassandra:** make cassandra dependency optional/test-only ([#518](#518)) ([bddbaeb](bddbaeb)) * **core:** allow setting docker command path for docker compose ([#512](#512)) ([63fcd52](63fcd52)) * **google:** add support for Datastore emulator ([#508](#508)) ([3d891a5](3d891a5)) * Improved Oracle DB module ([#363](#363)) ([6e6d8e3](6e6d8e3)) * inconsistent test runs for community modules ([#497](#497)) ([914f1e5](914f1e5)) * **kafka:** Add redpanda testcontainer module ([#441](#441)) ([451d278](451d278)) * **kafka:** wait_for_logs in kafka container to reduce lib requirement ([#377](#377)) ([909107b](909107b)) * **keycloak:** container should use dedicated API endpoints to determine container readiness ([#490](#490)) ([2e27225](2e27225)) * **nats:** Client-Free(ish) NATS container ([#462](#462)) ([302c73d](302c73d)) * **new:** add a new Docker Registry test container ([#389](#389)) ([0f554fb](0f554fb)) * pass doctests, s/doctest/doctests/, run them in gha, s/asyncpg/psycopg/ in doctest, fix keycloak flakiness: wait for first user ([#505](#505)) ([545240d](545240d)) * pass updated keyword args to Publisher/Subscriber client in google/pubsub [#161](#161) ([#164](#164)) ([8addc11](8addc11)) * Qdrant module ([#463](#463)) ([e8876f4](e8876f4)) * remove accidentally added pip in dev dependencies ([#516](#516)) ([dee20a7](dee20a7)) * **ryuk:** Enable Ryuk test suite. Ryuk image 0.5.1 -> 0.7.0. Add RYUK_RECONNECTION_TIMEOUT env variable ([#509](#509)) ([472b2c2](472b2c2)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Thanks a lot for merging this, @alexanderankin! |
@gvenzl thank you for your contribution! |
Hi,
I took the liberty to improve the Oracle DB module for Testcontainers Python. The PR has several enhancements:
oracledb
thin Python drivergvenzl/oracle-free
image with the latest and greatest Oracle DB versiongvenzl/oracle-free
image features (ORACLE_DATABASE
,APP_USER
,APP_USER_PASSWORD
, etc)Ideally, some more documentation on how the Container is supposed to be used would be handy but I couldn't really find a good example of how such a ReadMe should be structured.
Any things are gladly appreciated!