Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for aria-disabled attribute #302

Conversation

rlaffers
Copy link

@rlaffers rlaffers commented Oct 22, 2020

What:

Adding support for aria-disabled attribute in toBeDisabled and toBeEnabled matchers.

Why:

aria-disabled is a standard attribute with semantics similar to the disabled attribute. Until now, this attribute has been ignored by toBeDisabled and toBeEnabled matchers.

How:

By extending toBeDisabled and toBeEnabled matchers.

Checklist:

  • Documentation
  • Tests
  • Updated Type Definitions N/A
  • Ready to be merged

Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was discussed at length in #144. Could you continue the discussion there? If you want to propose an implementation please address all the points raised in #144.

@gnapse
Copy link
Member

gnapse commented Oct 22, 2020

I'll add a note in the README to the documentation of these matchers.

@gnapse
Copy link
Member

gnapse commented Oct 22, 2020

Please check #303.

@rlaffers
Copy link
Author

Thanks for pointing out the discussion in #144 . (I had not come across it although I searched for issues mentioning toBeDisabled; only open issues though). The reasoning for not adding this to toBeDisabled is sound and I agree with it. I'm closing this PR.

@rlaffers rlaffers closed this Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants