Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Bump testing-library/dom to v8 alpha #923

Merged
merged 1 commit into from
Jun 8, 2021

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Jun 8, 2021

BREAKING CHANGE: Bumps @testing-library/dom to 8.0.0-alpha.3.

For a comprehensive list of breaking changes see the individual releases:

What:

Why:

To propagate all the fixes/features from @testing-library/dom

How:

Bump @testing-library/dom to 8.0.0-alpha.3. The stable release of /react@12.x will use the stable release of /dom@8.x

Checklist:

  • [ ] Documentation added to the
    docs site
  • [ ] Tests
  • [ ] Typescript definitions updated
  • Ready to be merged

@eps1lon eps1lon added the BREAKING CHANGE This change will require a major version bump label Jun 8, 2021
@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 8, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 64c0d2f:

Sandbox Source
React Configuration
react-testing-library-examples Configuration

@codecov
Copy link

codecov bot commented Jun 8, 2021

Codecov Report

❗ No coverage uploaded for pull request base (alpha@875ee5b). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             alpha      #923   +/-   ##
=========================================
  Coverage         ?   100.00%           
=========================================
  Files            ?         4           
  Lines            ?       140           
  Branches         ?        28           
=========================================
  Hits             ?       140           
  Misses           ?         0           
  Partials         ?         0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 875ee5b...64c0d2f. Read the comment docs.

@eps1lon
Copy link
Member Author

eps1lon commented Jun 8, 2021

Merging since it's targetting an alpha branch and not changing anything that wasn't discussed in the dom-testing-library changes.

@eps1lon eps1lon changed the title fix: Bump testing-library/dom to v8 fix: Bump testing-library/dom to v8 alpha Jun 8, 2021
@eps1lon eps1lon merged commit 770246e into testing-library:alpha Jun 8, 2021
@eps1lon eps1lon deleted the fix/bump-dtl branch June 8, 2021 09:30
@github-actions
Copy link

github-actions bot commented Jun 8, 2021

🎉 This PR is included in version 11.2.8-alpha.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version 12.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BREAKING CHANGE This change will require a major version bump released on @alpha released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant