Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use https dtd url #480

Merged
merged 3 commits into from
Mar 10, 2020
Merged

use https dtd url #480

merged 3 commits into from
Mar 10, 2020

Conversation

missedone
Copy link
Collaborator

No description provided.

@missedone missedone requested a review from cbeust March 10, 2020 02:22

/** The URL to the TestNG DTD. */
public static final String TESTNG_DTD_URL = "http://testng.org/" + TESTNG_DTD;
public static final String TESTNG_DTD_URL = "https://testng.org/" + TESTNG_DTD;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use the https dtd url

@@ -216,8 +216,8 @@ protected static IFile showSelectionDialog(IResource[] choices) {
}

protected static IResource[] searchSuites(IResource[] scopeResources) {
ISearchQuery query= new FileSearchQuery("<!DOCTYPE suite SYSTEM \"http://testng.org/testng-1.0.dtd\" >",
false /*regexp*/ ,
ISearchQuery query= new FileSearchQuery("<!DOCTYPE suite SYSTEM \"(http|https)://testng.org/testng-1.0.dtd\" >",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

search both http and https

@missedone missedone merged commit 9b7f85c into master Mar 10, 2020
@missedone missedone deleted the https_dtd branch March 10, 2020 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant