fix: receive router deployment selector labels #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pod selector labels on the receive router deployment include the
version label. Selector labels are immutable and this prevents updating the
receive router.
```
Deployment/monitoring/thanos-receive-router dry-run failed, reason: Invalid, error: Deployment.apps "thanos-receive-router" is invalid: spec.selector: Invalid value: v1.LabelSelector{MatchLabels:map[string]string{"app.kubernetes.io/component":"thanos-receive-router", "app.kubernetes.io/instance":"thanos-receive", "app.kubernetes.io/name":"thanos-receive", "app.kubernetes.io/version":"v0.30.2"}, MatchExpressions:[]v1.LabelSelectorRequirement(nil)}: field is immutable
```
Signed-off-by: Daniel Schaaff <daniel@danielschaaff.com>
Signed-off-by: Daniel Schaaff <daniel@danielschaaff.com>
|
Hi @philipgough, @douglascamata, @metalmatze Would it be possible to get this PR reviewed and merged? @dschaaff would you be able to resolve conflicts? |
|
@michael-burt out of all the people you pinged, only @metalmatze is a maintainer, but he hasn't been active in the project. The others are just contributors (like @philipgough) or triagers (like me), without merge rights. Please ask for a review in the #thanos-dev channel in the CNCF slack, that's the right place. |
|
I can review and approve, but I can't merge. |
douglascamata
approved these changes
May 2, 2024
|
Also, Github is telling me that there are conflicts in this branch that must be solved. |
Signed-off-by: Daniel Schaaff <daniel@danielschaaff.com>
|
I've resolved the conflicts |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pod selector labels on the receive router deployment include the version label. Selector labels are immutable and this prevents updating the receive router.
Signed-off-by: Daniel Schaaff daniel@danielschaaff.com
Changes
Verification