Hedged-request: Handling in HTTP Client Configuration #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vanshikav123 <vanshikav928@gmail.com>
2 tasks
Signed-off-by: Vanshikav123 <vanshikav928@gmail.com>
Signed-off-by: Vanshikav123 <vanshikav928@gmail.com>
Signed-off-by: Vanshikav123 <vanshikav928@gmail.com>
GiedriusS
requested changes
May 24, 2024
GiedriusS
reviewed
May 31, 2024
| case string(AZURE): | ||
| bucket, err = azure.NewBucket(logger, config, component) | ||
| bucket, err = azure.NewBucket(logger, config, component, rt) | ||
| case string(SWIFT): | ||
| bucket, err = swift.NewContainer(logger, config) |
There was a problem hiding this comment.
It's not supported by all providers? 🤔 I checked a few like swift/bos and I don't see a reason why this is not implemented there.
There was a problem hiding this comment.
It's not supported by all providers? 🤔 I checked a few like swift/bos and I don't see a reason why this is not implemented there.
i added this parameter to the providers which had http.Client , swift does not uses NewBucket but bos/obs can have this parameter i think also i see that obs makes new ObsClient and bos uses NewClient which makes a BOS client...wdyt?
Signed-off-by: Vanshikav123 <vanshikav928@gmail.com>
Signed-off-by: Vanshikav123 <vanshikav928@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Initiation change for
thanos-io/thanos#6712
Implemented changes requested for #118
Verification