Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for object attributes in Iter call #63

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add support for object attributes in Iter call #63

wants to merge 3 commits into from

Commits on Jul 14, 2023

  1. Add support for object attributes in Iter call 

    This commit adds support for passing in object attributes to the Iter
callback. This PR makes a breaking change to the API since it adds
a new parameter to the callback. The option is currently supported
for GCS and Filesystem buckets only, but can be extended to other
providers on demand.

An alternative implementation would be to add a new IterWithAttrs
method and implement it only for a subset of providers. This will
avoid a breaking change and will make the support of the feature
more explicit. The downside is we need a new interface for something
that is only an option and that could be supported for all providers
in the future.

Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
    @fpetkovski
    fpetkovski committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    f7920a7 View commit details
    Browse the repository at this point in the history

  2. Fix abs path bug 

    Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
    @fpetkovski
    fpetkovski committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    1dbb3ea View commit details
    Browse the repository at this point in the history

  3. Remove testify dep 

    Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
    @fpetkovski
    fpetkovski committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    79ce462 View commit details
    Browse the repository at this point in the history