GCS: use Query.SetAttrSelection when listing objects #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andy Asp <andy.asp@grafana.com>
Signed-off-by: Andy Asp <andy.asp@grafana.com>
|
Oh, I wonder if this can help with thanos-io/thanos#6707. |
|
Let me test this out on a large bucket and we should be good to merge. |
fpetkovski
approved these changes
Sep 13, 2023
|
🎉 thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Uses Query.SetAttrSelection to only populate the
Namefield inIterfor GCS since it's the only object field used. It is suggested in the documentation near the bottom of this section. In case it confuses anyone else besides mePrefixisn't an option available to set (reference) and isn't affected.Verification
Locally performed recursive and non-recursive listings both with this change and without against a development bucket. The listing results were identical. I did not attempt to measure a performance impact myself.