-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Bucket Web UI view: Front-end hero wanted! 💖 #2149
Comments
I'll will work on it if nobody is working on it yet |
Hi, @bwplotka @geobeau Let's discuss key concepts.
Definitely agree.
From my point of view, it would be nice to see the following things:
At least I would avoid shortcuts like
See 2 :) |
@bwplotka @d-ulyanov opened a pull request with some improvements on the hover tooltip |
I have to look more into it, right now it really depends on Google Charts and it's a SVG so it's not possible to use normal HTML in it |
Thanks all for help!
Yes that's the problem. We are not tied to the library. We can change if we want. It was causing many problems already. I could see @geobeau you already did some PR. That's amazing! But can we first agree if we want to improve current UI or actually move it to React? Reason is that we already move all UIs including Prometheus ones to React so it might be more long term solution... Wdyt? @adrien-f @geobeau @d-ulyanov ? 🤔 |
If Prometheus is definitely moving to React, it makes sense to move everything to React (it seems to be the goal of #2124). More generally, using vanilla JS is nice when the code is simple (what we have today for I'll try to search for alternative Timetable graph libraries that could be more suitable and customisable. |
Let's migrate to React. Current UI is too primitive, partially not understandable and buggy - that's why I personally ready to invest our time in that. The graph looks quite simple, so I think it would not be difficult to reimplement it from scratch. |
I would say let's do it... Together! @adrien-f @d-ulyanov @geobeau and synchronize some work. Let's produce some work plans and distribute the task. We can definitely make this quicker if we can review each other code!
We are talking about Bucket UI here?
Yes @geobeau . Please help us by reviewing it. Your review will count as maintainer review if done carefully! We don't know much of React right now in Thanos Team (: We could use some help. Who knows, maybe we would need official Thanos team member who would help with some Frontend work? ❤️ No other blocker, we already agreed on Thanos sync that we want this. |
What do you think about setting some quick 30m call about this initiative? Not only bucket UI but have consistent react UI for Thanos? (basing on Prometheus one)? |
I prefer Slack if that's possible.
I'm a beginner with React as well. |
Is the color code documented anywhere? Can this be a simple document fix before rewrite? |
It's not and I don't think it means anything ;p
…On Tue, 25 Feb 2020 at 16:42, ibmdcb ***@***.***> wrote:
Is the color code documented anywhere? Can this be a simple document fix
before rewrite?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2149?email_source=notifications&email_token=ABVA3OYUU45D4VZKBY2TWKTREVC6VA5CNFSM4KXH2FIKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEM4TWDY#issuecomment-590953231>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABVA3O7R6O642GCXCWCRCGDREVC6VANCNFSM4KXH2FIA>
.
|
sorry for a slow answering :) |
@adrien-f @geobeau @d-ulyanov @squat Short meeting on slack/Hangouts this Friday morning (11am? CET) |
@geobeau are you joining us? (: |
This ticket is now included in #2198 **This should be improved only once we have React Block Viewer ready. ** |
I wrote the original web UI in an afternoon to find out where we had compaction backlogs (we run some really large clusters at $WORK) and @bwplotka convinced me to upstream the patches over a few beers. All mistakes are mine and I'll be really grateful to anyone who can improve this, specifically,
I'm cheering for you all! Yay. 🎉 |
Thanks @jaseemabid, you inspired us with the fact that UI can be very important part of the projects as the bucket viewer, even in basic form helped so many users already! 💪 BTW this project is now part of GSoC proposed project, so hopefully, we will have someone full time on this: https://github.com/cncf/soc#enriching-and-extending-thanos-uis-with-react-for-awesome-user-experience Also please share the doc linked here in your countries and universities so we have diverse proposals. 🤗 |
We found many heroes and we are starting work with our potential GSoC candidate @prmsrswt here: #2198 (: |
Our bucket web UI documented here is super useful. However, the first iteration was done with simplifications. It is functional but not really clear. (See this for example of user question on slack). You can find the reasons of simplifications for the current implementation here.
Let's define some AC, of what I think we could add, but feedback is welcome as well:
AC:
block.MetaFetcher
Potentially we could rewrite this to React as we already move our UI to React as Prometheus does: #2124
cc @adrien-f @squat @jaseemabid
Help wanted! 🤗
The text was updated successfully, but these errors were encountered: