querier: Allow passing allow-list of store (IPs?) that should be used for query for debug purposes; Add multiselect on UI

[bwplotka]

It would be awesome to add the ability to query only a subset of stores to detect which one is slow/ problematic etc (: It should be hidden option only for ad-hoc query.

[geobeau]

I am interested in doing it.

After looking at how to implement it, I have a design question: the query api uses the proxy as a storepb.StoreServer and the logic behind the store selection is done after calling storepb.StoreServer.Series(), however there is no way of passing an allowlist without extending the interface. Would be okay to change querier.proxy to use directly ProxyStore in place of storepb.StoreServer?

[bwplotka]

Awesome. I think it would be nice to avoid passing this in protobuf, but we could technically create some hints.

I would also avoid running just ProxyStore and changing methods.

We have two options:

1. Pass through context as a best-effort thing
2. Extend protobuf

I would start for now with 1 and then 2 long term. WDYT? (:

[geobeau]

Pass through context seems good for me. 👍

[geobeau]

Hello, can you take a look at #2931 ? It's still in WIP as I need to finish the testing but I would like your input first.

[bwplotka]

I did, and left some comments. Good approach overall!

…

On Thu, 23 Jul 2020 at 20:28, Geoffrey Beausire ***@***.***> wrote: Hello, can you take a look at #2931 <#2931> ? It's still in WIP as I need to finish the testing but I would like your input first. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#2919 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABVA3OYFGYSDIIH7Z5Z4Y4TR5CFMRANCNFSM4PEPKKAA> .

[stale]

Hello 👋 Looks like there was no activity on this issue for last 30 days.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity for next week, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

[bwplotka]

It's now done in #2931 and documented.