Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block viewer: New UI extension ideas #3112

Open
1 of 8 tasks
bwplotka opened this issue Sep 2, 2020 · 29 comments
Open
1 of 8 tasks

Block viewer: New UI extension ideas #3112

bwplotka opened this issue Sep 2, 2020 · 29 comments
Labels
component: UIs/ReactJS dont-go-stale Label for important issues which tells the stalebot not to close them feature request/improvement help wanted

Comments

@bwplotka
Copy link
Member

bwplotka commented Sep 2, 2020

It looks amazing (zoom out view 75%):

image

And works well, but some minor nits that come to my mind if someone has spare cycles:

  • It takes to much vertical space, I think I would reduce vertical whitespace to a minimum.
  • It would be amazing to just group them by all external labels (no config needed?)
  • Show different statuses as different colors / details on global view
  • Vertical lines for some grid like on old UI?
  • Stats on top: when was the last refresh, how many blocks overall, how many blocks in each group (?)
  • Search input that will allow to group them on certain labels?
  • It would be amazing if we can someday add extra stats like (for loaded page):
    • What blocks are currently being compacted, downsampled! (:
  • Using different colors is ok ;p (same as we use for coloring graphs)

cc @prmsrswt

@kunal-kushwaha
Copy link
Contributor

I'd like to take this 🙌

@daksh-sagar
Copy link
Contributor

@bwplotka are we talking about the vertical whitespace that is present between the blocks like in the first row in the above image?

@bwplotka
Copy link
Member Author

Are you talking about first action item? We would like to reduce it to a minimum. First row blocks show some overlapping blocks that's why they are close. We need to make sure it's closer but not too much to show that those are for different external labels (:

@daksh-sagar
Copy link
Contributor

daksh-sagar commented Sep 24, 2020

I've made some changes, this is what it looks like right now. What do you think @bwplotka ?
blocks

@bwplotka
Copy link
Member Author

It looks better! 💪 Looking forward for a PR (:

@daksh-sagar
Copy link
Contributor

@prmsrswt Need help regarding 5th action item: "display stats on top". How should it be displayed (visually) ?

@daksh-sagar
Copy link
Contributor

I'm working on the 5th action item. This is how I'm displaying refreshed at, total blocks, and blocks in each group. Can I have your feedback please.
@prmsrswt @bwplotka
stats

@aribalam
Copy link
Contributor

@daksh-sagar Just out of curiosity, How do I access the Block Viewer using the Thanos Query UI (as given in the picture above). I was unable to access it using a dockerized setup. I was only able to use it through the Bucket Web and the Compactor component.
@prmsrswt Is there anything I am missing out?

@daksh-sagar
Copy link
Contributor

@aribalam You need to uncomment the bucket-web in the docker-compose file and then change the proxy in the package.json to port 8080. Let me know if you need to know anything else.

@aribalam
Copy link
Contributor

@daksh-sagar The commenting part is alright but in my opinion, I don't think it's necessary to change the proxy as it is handled accordingly. You just have to visit the dedicated port (i.e localhost:8080/blocks) instead of localhost:10902/blocks, which is dedicated to the Query component.
I am just wondering if it's alright to access the Block Viewer through the Query UI.
@prmsrswt Any thoughts on this?

@daksh-sagar
Copy link
Contributor

@aribalam I thought you were accessing the react-app through the thanos repo on your local machine.

@Oghenebrume50
Copy link
Contributor

Oghenebrume50 commented Sep 26, 2020

I also have problems accessing the block viewer I should try @aribalam method

PS: tried that and no need to change the proxy in package.json actually

kunal-kushwaha added a commit to kunal-kushwaha/thanos that referenced this issue Nov 19, 2020
kunal-kushwaha added a commit to kunal-kushwaha/thanos that referenced this issue Nov 19, 2020
Signed-off-by: Kunal Kushwaha <kunalkushwaha453@gmail.com>
kunal-kushwaha added a commit to kunal-kushwaha/thanos that referenced this issue Nov 19, 2020
Signed-off-by: Kunal Kushwaha <kunalkushwaha453@gmail.com>
@stale
Copy link

stale bot commented Nov 26, 2020

Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

@stale stale bot added the stale label Nov 26, 2020
@kunal-kushwaha
Copy link
Contributor

In progress!

@stale stale bot removed the stale label Nov 26, 2020
@stale
Copy link

stale bot commented Jan 25, 2021

Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

@stale stale bot added the stale label Jan 25, 2021
@kunal-kushwaha
Copy link
Contributor

Still valid

@kakkoyun
Copy link
Member

Help wanted 🤗

@stale stale bot removed the stale label Feb 10, 2021
@EmperorYP7
Copy link

Hello everyone! 🙋🏻
I'd like to work on this. I did submit my application for the same on the LFX Mentorship portal. Looking forward to learning a lot from the community! 🙌🏻

@NBNARADHYA
Copy link

NBNARADHYA commented May 13, 2021

Hey guys 🙋‍♂️, I'm Nikhil.

I saw this project on the LFX Mentorship site and it needs a mentee for the project. I have applied for this project on the LFX Mentorship website and I would love to work on this ! 😃

@stale
Copy link

stale bot commented Jul 13, 2021

Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

@stale
Copy link

stale bot commented Sep 19, 2021

Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

@stale stale bot added the stale label Sep 19, 2021
@stale
Copy link

stale bot commented Oct 12, 2021

Closing for now as promised, let us know if you need this to be reopened! 🤗

@stale stale bot closed this as completed Oct 12, 2021
@yeya24 yeya24 reopened this Oct 13, 2021
@stale
Copy link

stale bot commented Oct 30, 2021

Closing for now as promised, let us know if you need this to be reopened! 🤗

@stale stale bot closed this as completed Oct 30, 2021
@yeya24
Copy link
Contributor

yeya24 commented Oct 30, 2021

Still valid

@yeya24 yeya24 reopened this Oct 30, 2021
@stale stale bot removed stale labels Oct 30, 2021
@stale
Copy link

stale bot commented Jan 9, 2022

Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

@stale stale bot added the stale label Jan 9, 2022
@stale
Copy link

stale bot commented Mar 2, 2022

Closing for now as promised, let us know if you need this to be reopened! 🤗

@stale stale bot closed this as completed Mar 2, 2022
@matej-g matej-g reopened this Mar 3, 2022
@stale stale bot removed the stale label Mar 3, 2022
@stale
Copy link

stale bot commented May 2, 2022

Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

@stale stale bot added the stale label May 2, 2022
@GiedriusS GiedriusS added dont-go-stale Label for important issues which tells the stalebot not to close them and removed stale labels May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: UIs/ReactJS dont-go-stale Label for important issues which tells the stalebot not to close them feature request/improvement help wanted
Projects
None yet
Development

No branches or pull requests