query/api: properly pass downsampling param #1144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As compact.ResolutionLevel{Raw,5m,1h} says the resolution levels are
expressed in milliseconds. Currently, parseDownsamplingParam() calls
parseDuration() and friends which express this value in nanoseconds.
Thus, we need to divide the value by 1000*1000 to have them in
milliseconds.
Add test cases to check all of this.
|
this lgtm, but we should note this change in the changelog |
povilasv
approved these changes
May 15, 2019
brancz
approved these changes
May 15, 2019
|
Wow 😱 |
|
I think we should close like at least 3 tickets mentioning that choosing downsampling does not always work ;p |
|
This is wrong change IMO - the time is being divided to match miliseconds further down in stack ): And we are trying to somehow adjust unit in vatiable with unit agnostic type - time.Duration ): Hopefully we are on it here: #1146 Consequence is that downsampling is technically never working now. Should we revert this maybe? Unless I am wrong @GiedriusS (: |
bwplotka
added a commit
that referenced
this pull request
May 16, 2019
This reverts commit 7a767ef. # Conflicts: # CHANGELOG.md
This was referenced May 16, 2019
bwplotka
added a commit
that referenced
this pull request
May 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As compact.ResolutionLevel{Raw,5m,1h} says the resolution levels are
expressed in milliseconds. Currently, parseDownsamplingParam() calls
parseDuration() and friends which express this value in nanoseconds.
Thus, we need to divide the value by 1000*1000 to have them in
milliseconds.
Add test cases to check all of this.