Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

query/querier: fix sum() inflated values problem #1278

Merged
merged 7 commits into from
Jun 27, 2019
Merged

query/querier: fix sum() inflated values problem #1278

merged 7 commits into from
Jun 27, 2019

Commits on Jun 25, 2019

  1. query/querier_test: add minimal test for typical setup 

    Add a test for a typical setup of one Sidecar connected + one or more
Thanos Store nodes. Testing how the whole thing really works.
    Giedrius Statkevičius committed Jun 25, 2019
    Configuration menu
    Copy the full SHA
    1601ab1 View commit details
    Browse the repository at this point in the history

  2. query/querier_test: fix test 

    It is to be expected that Prometheus code will select the latest value
in any time window because otherwise the implicit conversion between raw
and pre-aggregated would not work.
    Giedrius Statkevičius committed Jun 25, 2019
    Configuration menu
    Copy the full SHA
    971bf63 View commit details
    Browse the repository at this point in the history

  3. query: improve test, switch around iter

    Giedrius Statkevičius committed Jun 25, 2019
    Configuration menu
    Copy the full SHA
    0a6a75b View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2019

  1. querier: fix sum() data request

    Giedrius Statkevičius committed Jun 26, 2019
    Configuration menu
    Copy the full SHA
    53e940c View commit details
    Browse the repository at this point in the history

  2. query/iter: revert change 

    This is not needed.
    Giedrius Statkevičius committed Jun 26, 2019
    Configuration menu
    Copy the full SHA
    9ae7489 View commit details
    Browse the repository at this point in the history

  3. query/querier: add explanatory comment

    Giedrius Statkevičius committed Jun 26, 2019
    Configuration menu
    Copy the full SHA
    49c2517 View commit details
    Browse the repository at this point in the history

  4. query/querier_test: fix tests

    Giedrius Statkevičius committed Jun 26, 2019
    Configuration menu
    Copy the full SHA
    e168d2d View commit details
    Browse the repository at this point in the history