Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bucket inspect timeout flag #1533

Merged
merged 2 commits into from
Sep 17, 2019
Merged

Add bucket inspect timeout flag #1533

merged 2 commits into from
Sep 17, 2019

Conversation

jdfalk
Copy link
Contributor

@jdfalk jdfalk commented Sep 17, 2019

Signed-off-by: Johnathan Falk johnathan.falk@gmail.com

Fixes #1532

  • CHANGELOG entry if change is relevant to the end user.

Changes

Added timeout flag to bucket inspect

Verification

Built and run

Signed-off-by: Johnathan Falk <johnathan.falk@gmail.com>
Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@bwplotka
Copy link
Member

You marked CHANGELOG as done in the PR description template, but can't see the change ): I guess it would be nice to add an item to changelog?

@jdfalk
Copy link
Contributor Author

jdfalk commented Sep 17, 2019

Crud. I updated the components doc but not the change long. Will add.

Signed-off-by: Johnathan Falk <johnathan.falk@gmail.com>
@bwplotka
Copy link
Member

Thanks!

@bwplotka bwplotka merged commit b7739b7 into thanos-io:master Sep 17, 2019
wbh1 pushed a commit to wbh1/thanos that referenced this pull request Sep 17, 2019
* Add bucket inspect timeout.

Signed-off-by: Johnathan Falk <johnathan.falk@gmail.com>

* Added change log entry.

Signed-off-by: Johnathan Falk <johnathan.falk@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bucket: Add timeout to thanos bucket inspect
2 participants