Promote sidecar shipper.upload-compacted flag to non hidden, non experimental state. #1833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squat
approved these changes
Dec 3, 2019
docs/quick-tutorial.md
Outdated
| @@ -93,6 +93,11 @@ thanos sidecar \ | |||
|
|
|||
| * _[Example Kubernetes manifests using Prometheus operator](https://github.com/coreos/prometheus-operator/tree/master/example/thanos)_ | |||
|
|
|||
| ### Uploading old metrics. | |||
|
|
|||
| When sidecar is ran wit `--shipper.upload-compacted` flag it will sync all older existing blocks from the Prometheus local storage on startup. | |||
There was a problem hiding this comment.
When the sidecar is run with the --...
docs/quick-tutorial.md
Outdated
| ### Uploading old metrics. | ||
|
|
||
| When sidecar is ran wit `--shipper.upload-compacted` flag it will sync all older existing blocks from the Prometheus local storage on startup. | ||
| NOTE: This assumes you never run sidecar with block uploading against this bucket. Otherwise manual steps are needed to remove overlapping blocks from bucket. |
…rimental state. Signed-off-by: Bartek Plotka <bwplotka@gmail.com>
squat
approved these changes
Dec 4, 2019
|
Hmm could we have a race? |
povilasv
approved these changes
Dec 5, 2019
|
@squat Will look on that. Not introduced by this PR for sure (: |
|
Yes that’s for sure. We’ll need to do a bit of digging to identify. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Bartek Plotka bwplotka@gmail.com