Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add memcached support to index cache #1881

Merged
merged 34 commits into from
Jan 3, 2020
Merged

Add memcached support to index cache #1881

merged 34 commits into from
Jan 3, 2020

Commits on Jan 3, 2020

  1. Moved index cache key struct outside of the file containing the in-me… 

    …mory cache backend because generic

Signed-off-by: Marco Pracucci <marco@pracucci.com>
    @pracucci
    pracucci committed Jan 3, 2020
    Configuration menu
    Copy the full SHA
    cc101b8 View commit details
    Browse the repository at this point in the history

  2. Added cacheKey.string() to make it memcached friendly 

    Signed-off-by: Marco Pracucci <marco@pracucci.com>
    @pracucci
    pracucci committed Jan 3, 2020
    Configuration menu
    Copy the full SHA
    ba6af3d View commit details
    Browse the repository at this point in the history

  3. Added MemcachedIndexCache support 

    Signed-off-by: Marco Pracucci <marco@pracucci.com>
    @pracucci
    pracucci committed Jan 3, 2020
    Configuration menu
    Copy the full SHA
    0f57c95 View commit details
    Browse the repository at this point in the history

  4. Export Prometheus metrics from MemcachedIndexCache 

    Signed-off-by: Marco Pracucci <marco@pracucci.com>
    @pracucci
    pracucci committed Jan 3, 2020
    Configuration menu
    Copy the full SHA
    aaa15f4 View commit details
    Browse the repository at this point in the history

  5. Fixed linter issues 

    Signed-off-by: Marco Pracucci <marco@pracucci.com>
    @pracucci
    pracucci committed Jan 3, 2020
    Configuration menu
    Copy the full SHA
    60b23d4 View commit details
    Browse the repository at this point in the history

  6. Simplified workers wait group in memcachedClient 

    Signed-off-by: Marco Pracucci <marco@pracucci.com>
    @pracucci
    pracucci committed Jan 3, 2020
    Configuration menu
    Copy the full SHA
    b114623 View commit details
    Browse the repository at this point in the history

  7. Fixed memcached client GetMulti() results batches channel buffer 

    Signed-off-by: Marco Pracucci <marco@pracucci.com>
    @pracucci
    pracucci committed Jan 3, 2020
    Configuration menu
    Copy the full SHA
    4afe30a View commit details
    Browse the repository at this point in the history

  8. Wait for addrs resolution gorouting to complete on memcachedClient.St… 

    …op()

Signed-off-by: Marco Pracucci <marco@pracucci.com>
    @pracucci
    pracucci committed Jan 3, 2020
    Configuration menu
    Copy the full SHA
    bcc5ceb View commit details
    Browse the repository at this point in the history

  9. Return struct from NewMemcachedClient() 

    Signed-off-by: Marco Pracucci <marco@pracucci.com>
    @pracucci
    pracucci committed Jan 3, 2020
    Configuration menu
    Copy the full SHA
    ebd9af0 View commit details
    Browse the repository at this point in the history

  10. Update pkg/cacheutil/memcached_client.go 

    Co-Authored-By: Bartlomiej Plotka <bwplotka@gmail.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
    @pracucci @bwplotka
    pracucci and bwplotka committed Jan 3, 2020
    Configuration menu
    Copy the full SHA
    4581111 View commit details
    Browse the repository at this point in the history

  11. Simplified memcachedClient tests 

    Signed-off-by: Marco Pracucci <marco@pracucci.com>
    @pracucci
    pracucci committed Jan 3, 2020
    Configuration menu
    Copy the full SHA
    c9d37f9 View commit details
    Browse the repository at this point in the history

  12. Cleaned up code based on feedback 

    Signed-off-by: Marco Pracucci <marco@pracucci.com>
    @pracucci
    pracucci committed Jan 3, 2020
    Configuration menu
    Copy the full SHA
    77413ca View commit details
    Browse the repository at this point in the history

  13. Removed error from GetMulti() return and introduced metrics and traci… 

    …ng in MemcachedClient

Signed-off-by: Marco Pracucci <marco@pracucci.com>
    @pracucci
    pracucci committed Jan 3, 2020
    Configuration menu
    Copy the full SHA
    16d368a View commit details
    Browse the repository at this point in the history

  14. Fixed compilation errors in store E2E tests 

    Signed-off-by: Marco Pracucci <marco@pracucci.com>
    @pracucci
    pracucci committed Jan 3, 2020
    Configuration menu
    Copy the full SHA
    9178cdd View commit details
    Browse the repository at this point in the history

  15. Added leaktest check to all tests 

    Signed-off-by: Marco Pracucci <marco@pracucci.com>
    @pracucci
    pracucci committed Jan 3, 2020
    Configuration menu
    Copy the full SHA
    8951227 View commit details
    Browse the repository at this point in the history

  16. Introduced --index.cache-config support 

    Signed-off-by: Marco Pracucci <marco@pracucci.com>
    @pracucci
    pracucci committed Jan 3, 2020
    Configuration menu
    Copy the full SHA
    390e93c View commit details
    Browse the repository at this point in the history

  17. Fixed compilation errors in store E2E tests 

    Signed-off-by: Marco Pracucci <marco@pracucci.com>
    @pracucci
    pracucci committed Jan 3, 2020
    Configuration menu
    Copy the full SHA
    702dc82 View commit details
    Browse the repository at this point in the history

  18. Updated store flags doc 

    Signed-off-by: Marco Pracucci <marco@pracucci.com>
    @pracucci
    pracucci committed Jan 3, 2020
    Configuration menu
    Copy the full SHA
    bf5dd7c View commit details
    Browse the repository at this point in the history

  19. Updated index cache doc 

    Signed-off-by: Marco Pracucci <marco@pracucci.com>
    @pracucci
    pracucci committed Jan 3, 2020
    Configuration menu
    Copy the full SHA
    fb6d122 View commit details
    Browse the repository at this point in the history

  20. Updated changelog 

    Signed-off-by: Marco Pracucci <marco@pracucci.com>
    @pracucci
    pracucci committed Jan 3, 2020
    Configuration menu
    Copy the full SHA
    a7c20f2 View commit details
    Browse the repository at this point in the history

  21. Increased default memcached client timeout from 100ms to 500ms 

    Signed-off-by: Marco Pracucci <marco@pracucci.com>
    @pracucci
    pracucci committed Jan 3, 2020
    Configuration menu
    Copy the full SHA
    e2c72a0 View commit details
    Browse the repository at this point in the history

  22. Disabled memcached client max batch size by default 

    Signed-off-by: Marco Pracucci <marco@pracucci.com>
    @pracucci
    pracucci committed Jan 3, 2020
    Configuration menu
    Copy the full SHA
    f8b318e View commit details
    Browse the repository at this point in the history

  23. Fixed index cache key max length 

    Signed-off-by: Marco Pracucci <marco@pracucci.com>
    @pracucci
    pracucci committed Jan 3, 2020
    Configuration menu
    Copy the full SHA
    491c5bb View commit details
    Browse the repository at this point in the history

  24. Removed TODO from memcached client since looks the general consensus … 

    …is to have a global limit on the max concurrent batches

Signed-off-by: Marco Pracucci <marco@pracucci.com>
    @pracucci
    pracucci committed Jan 3, 2020
    Configuration menu
    Copy the full SHA
    db9356b View commit details
    Browse the repository at this point in the history

  25. Allow to configure in-memory index cache using byte units 

    Signed-off-by: Marco Pracucci <marco@pracucci.com>
    @pracucci
    pracucci committed Jan 3, 2020
    Configuration menu
    Copy the full SHA
    bb3eb88 View commit details
    Browse the repository at this point in the history

  26. Refactored index cache config file doc 

    Signed-off-by: Marco Pracucci <marco@pracucci.com>
    @pracucci
    pracucci committed Jan 3, 2020
    Configuration menu
    Copy the full SHA
    1ea97b2 View commit details
    Browse the repository at this point in the history

  27. Fixed nits in comments 

    Signed-off-by: Marco Pracucci <marco@pracucci.com>
    @pracucci
    pracucci committed Jan 3, 2020
    Configuration menu
    Copy the full SHA
    08f1bd3 View commit details
    Browse the repository at this point in the history

  28. Replaced hardcoded 16 with ULID calculated length based on review com… 

    …ment

Signed-off-by: Marco Pracucci <marco@pracucci.com>
    @pracucci
    pracucci committed Jan 3, 2020
    Configuration menu
    Copy the full SHA
    f83b2d2 View commit details
    Browse the repository at this point in the history

  29. Do not expose jumpHash func 

    Signed-off-by: Marco Pracucci <marco@pracucci.com>
    @pracucci
    pracucci committed Jan 3, 2020
    Configuration menu
    Copy the full SHA
    b8b8517 View commit details
    Browse the repository at this point in the history

  30. Updated changelog 

    Signed-off-by: Marco Pracucci <marco@pracucci.com>
    @pracucci
    pracucci committed Jan 3, 2020
    Configuration menu
    Copy the full SHA
    f62a0b4 View commit details
    Browse the repository at this point in the history

  31. Switched MemcachedClient GetMulti() concurrency limit to a gate 

    Signed-off-by: Marco Pracucci <marco@pracucci.com>
    @pracucci
    pracucci committed Jan 3, 2020
    Configuration menu
    Copy the full SHA
    b2d822e View commit details
    Browse the repository at this point in the history

  32. Fixed flaky tests 

    Signed-off-by: Marco Pracucci <marco@pracucci.com>
    @pracucci
    pracucci committed Jan 3, 2020
    Configuration menu
    Copy the full SHA
    9113f0c View commit details
    Browse the repository at this point in the history

  33. Fixed typos in comments 

    Signed-off-by: Marco Pracucci <marco@pracucci.com>
    @pracucci
    pracucci committed Jan 3, 2020
    Configuration menu
    Copy the full SHA
    da13b4b View commit details
    Browse the repository at this point in the history

  34. Renamed memcached config option addrs to addresses 

    Signed-off-by: Marco Pracucci <marco@pracucci.com>
    @pracucci
    pracucci committed Jan 3, 2020
    Configuration menu
    Copy the full SHA
    f1482f2 View commit details
    Browse the repository at this point in the history