Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/thanos/receive: dont upload as sidecar #1882

Merged
merged 1 commit into from
Dec 13, 2019

Conversation

squat
Copy link
Member

@squat squat commented Dec 12, 2019

As pointed out by a user on the CNCF Slack, the receiver is currently
uploading to object storage as the sidecar.

cc @metalmatze @brancz

Signed-off-by: Lucas Servén Marín lserven@gmail.com

  • I added CHANGELOG entry for this change.

@@ -407,7 +407,7 @@ func runReceive(
if upload {
// The background shipper continuously scans the data directory and uploads
// new blocks to Google Cloud Storage or an S3-compatible storage service.
bkt, err := client.NewBucket(logger, confContentYaml, reg, component.Sidecar.String())
bkt, err := client.NewBucket(logger, confContentYaml, reg, component.Receive.String())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have the “comp” variable that we can use here no?

Copy link
Member Author

@squat squat Dec 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, absolutely right. it turns out we are explicitly using component.Receive somewhere else in this body as well because tsdb.NewTSDBStore expects a component.SourceStoreAPI, not just a component.Component. I'll change the function signature of runReceive and update both of these.

As pointed out by a user on the CNCF Slack, the receiver is currently
uploading to object storage as the sidecar.

Signed-off-by: Lucas Servén Marín <lserven@gmail.com>
@brancz brancz merged commit b45e532 into thanos-io:master Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants