store: support serving downsampled data from bucket #191
Conversation
fabxc
force-pushed
the
downsamplefixes
branch
from
a88225b
to
7306c96
Compare
pkg/store/bucket.go
Outdated
| chks []storepb.AggrChunk | ||
| set []seriesEntry | ||
| i int | ||
| // chks []storepb.AggrChunk |
pkg/store/bucket.go
Outdated
| if err != nil { | ||
| return errors.Errorf("aggregate %s does not exist", downsample.AggrSum) | ||
| } | ||
| out.Count = &storepb.Chunk{Type: storepb.Chunk_XOR, Data: x.Bytes()} |
|
|
||
| // getFor returns a time-ordered list of blocks that cover date between mint and maxt. | ||
| // Blocks with the lowest resolution possible but not lower than the given resolution are returned. | ||
| func (s *bucketBlockSet) getFor(mint, maxt, minResolution int64) (bs []*bucketBlock) { |
There was a problem hiding this comment.
how we got from req.MaxResolutionWindow to this minResolution name here? Also
for ; i < len(s.resolutions) && s.resolutions[i] > minResolution; i++ {}
Min resolution make sense here, but we are putting max Resolution in this parameter... Not sure what's going on here ^^
There was a problem hiding this comment.
That's essentially the issue about intuitively of naming we ran into before. MaxResolutionWindow and minResolution are in fact the same thing. If we set an upper bound on how big the window we aggregate over is that implies a minimum resolution we want to guarantee. If we made the window bigger, resolution would decrease.
fabxc
force-pushed
the
downsamplefixes
branch
4 times, most recently
from
3ecb602
to
9359c8c
Compare
fabxc
force-pushed
the
downstore
branch
2 times, most recently
from
134d1cc
to
85bb165
Compare
|
Fixed and added some tests. |
|
Gave this another review myself. I'll merge this now. There's one remaining comment on the naming confusion. If we come up with a better variant we can always change this later. |
|
Oke (: |
|
Is skiing weather so bad that you are on GH instead on 11am :P? |
Build with golang 1.20
@Bplotka
Definitely some tests missing overall – will add some later.