Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fx ruler ui alerts click #2040

Merged
merged 1 commit into from
Jan 25, 2020
Merged

Fx ruler ui alerts click #2040

merged 1 commit into from
Jan 25, 2020

Conversation

yeya24
Copy link
Contributor

@yeya24 yeya24 commented Jan 25, 2020

Signed-off-by: yeya24 yb532204897@gmail.com

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Fixes #2024

In #1854, I mistakenly changed the click behavior of the alerts section in Ruler UI.

Now change back to queryURL and it works now. I have already tested in my local env

Verification

Signed-off-by: yeya24 <yb532204897@gmail.com>
@squat
Copy link
Member

squat commented Jan 25, 2020

Nice :)

@squat squat merged commit cf4e450 into thanos-io:master Jan 25, 2020
@yeya24 yeya24 deleted the fix-rule-ui branch January 25, 2020 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Thanos-rule : Bad query url in Alerts view
2 participants