Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix2213 0.12 #2382

Merged
merged 2 commits into from
Apr 6, 2020
Merged

Fix2213 0.12 #2382

merged 2 commits into from
Apr 6, 2020

Commits on Apr 6, 2020

  1. binaryHeader: Fixed partial write issue for index-header. 

    Fixes thanos-io#2213

This caused was indicated as regression of latency, and also causes potential critical issue
for store GW, where manual delete of index-header from local storage was required.

This might be considered as blocker for 0.12, so it would be worth to port it to 0.12 TBH @squat.

Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
    @bwplotka @squat
    bwplotka authored and squat committed Apr 6, 2020
    Configuration menu
    Copy the full SHA
    3c1711e View commit details
    Browse the repository at this point in the history

  2. binary_reader: ensure fs is synced before renaming 

    Signed-off-by: Lucas Servén Marín <lserven@gmail.com>
    @squat
    squat committed Apr 6, 2020
    Configuration menu
    Copy the full SHA
    8c017d9 View commit details
    Browse the repository at this point in the history