Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chunks caching at bucket level #2532

Merged
merged 34 commits into from
May 7, 2020
Merged

Chunks caching at bucket level #2532

merged 34 commits into from
May 7, 2020

Commits on Apr 30, 2020

  1. Added generic cache interface. 

    Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
    @pstibrany
    pstibrany committed Apr 30, 2020
    Configuration menu
    Copy the full SHA
    93343ca View commit details
    Browse the repository at this point in the history

  2. Added memcached implementation of Cache. 

    Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
    @pstibrany
    pstibrany committed Apr 30, 2020
    Configuration menu
    Copy the full SHA
    515a0f7 View commit details
    Browse the repository at this point in the history

  3. Chunks-caching bucket. 

    Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
    @pstibrany
    pstibrany committed Apr 30, 2020
    Configuration menu
    Copy the full SHA
    967dd7a View commit details
    Browse the repository at this point in the history

  4. Fix sentences 

    Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
    @pstibrany
    pstibrany committed Apr 30, 2020
    Configuration menu
    Copy the full SHA
    c45f271 View commit details
    Browse the repository at this point in the history

  5. Fix sentences 

    Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
    @pstibrany
    pstibrany committed Apr 30, 2020
    Configuration menu
    Copy the full SHA
    4739c12 View commit details
    Browse the repository at this point in the history

  6. Fix sentences 

    Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
    @pstibrany
    pstibrany committed Apr 30, 2020
    Configuration menu
    Copy the full SHA
    f4c4783 View commit details
    Browse the repository at this point in the history

Commits on May 1, 2020

  1. Rename config objects. 

    Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
    @pstibrany
    pstibrany committed May 1, 2020
    Configuration menu
    Copy the full SHA
    1f6b415 View commit details
    Browse the repository at this point in the history

Commits on May 4, 2020

  1. Review feedback. 

    Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
    @pstibrany
    pstibrany committed May 4, 2020
    Configuration menu
    Copy the full SHA
    616891e View commit details
    Browse the repository at this point in the history

  2. Review feedback. 

    Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
    @pstibrany
    pstibrany committed May 4, 2020
    Configuration menu
    Copy the full SHA
    e0ffb00 View commit details
    Browse the repository at this point in the history

  3. Added metrics for object size. 

    Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
    @pstibrany
    pstibrany committed May 4, 2020
    Configuration menu
    Copy the full SHA
    000b5c3 View commit details
    Browse the repository at this point in the history

  4. Added requested chunk bytes metric. 

    Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
    @pstibrany
    pstibrany committed May 4, 2020
    Configuration menu
    Copy the full SHA
    7eb18db View commit details
    Browse the repository at this point in the history

  5. Caching bucket docs. 

    Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
    @pstibrany
    pstibrany committed May 4, 2020
    Configuration menu
    Copy the full SHA
    2b42af4 View commit details
    Browse the repository at this point in the history

  6. Fixed tests. 

    Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
    @pstibrany
    pstibrany committed May 4, 2020
    Configuration menu
    Copy the full SHA
    1baa24c View commit details
    Browse the repository at this point in the history

  7. Fix test. 

    Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
    @pstibrany
    pstibrany committed May 4, 2020
    Configuration menu
    Copy the full SHA
    801bc6d View commit details
    Browse the repository at this point in the history

Commits on May 5, 2020

  1. Update docs/components/store.md 

    Update pkg/store/cache/caching_bucket.go

Co-authored-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
    @pstibrany @pracucci
    pstibrany and pracucci committed May 5, 2020
    Configuration menu
    Copy the full SHA
    2997437 View commit details
    Browse the repository at this point in the history

  2. Dots 

    Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
    @pstibrany
    pstibrany committed May 5, 2020
    Configuration menu
    Copy the full SHA
    0c75120 View commit details
    Browse the repository at this point in the history

  3. Always set lastBlockOffset. 

    Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
    @pstibrany
    pstibrany committed May 5, 2020
    Configuration menu
    Copy the full SHA
    9821c29 View commit details
    Browse the repository at this point in the history

  4. Merged cached metric into fetched metric, added labels. 

    Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
    @pstibrany
    pstibrany committed May 5, 2020
    Configuration menu
    Copy the full SHA
    c35f077 View commit details
    Browse the repository at this point in the history

  5. Added CHANGELOG.md entry 

    Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
    @pstibrany
    pstibrany committed May 5, 2020
    Configuration menu
    Copy the full SHA
    c9b51b1 View commit details
    Browse the repository at this point in the history

  6. Reworded help for thanos_store_bucket_cache_fetched_chunk_bytes_total 

    Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
    @pstibrany
    pstibrany committed May 5, 2020
    Configuration menu
    Copy the full SHA
    65af4fb View commit details
    Browse the repository at this point in the history

  7. Added tracing around getRangeChunkFile method. 

    Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
    @pstibrany
    pstibrany committed May 5, 2020
    Configuration menu
    Copy the full SHA
    05f2b4a View commit details
    Browse the repository at this point in the history

  8. Updated CHANGELOG.md 

    Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
    @pstibrany
    pstibrany committed May 5, 2020
    Configuration menu
    Copy the full SHA
    015b025 View commit details
    Browse the repository at this point in the history

  9. Options 

    Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
    @pstibrany
    pstibrany committed May 5, 2020
    Configuration menu
    Copy the full SHA
    3386747 View commit details
    Browse the repository at this point in the history

Commits on May 6, 2020

  1. Fix parameter name. (store. got dropped by accident) 

    Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
    @pstibrany
    pstibrany committed May 6, 2020
    Configuration menu
    Copy the full SHA
    7269899 View commit details
    Browse the repository at this point in the history

  2. Use embedded Bucket 

    Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
    @pstibrany
    pstibrany committed May 6, 2020
    Configuration menu
    Copy the full SHA
    13ac200 View commit details
    Browse the repository at this point in the history

  3. Added comments. 

    Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
    @pstibrany
    pstibrany committed May 6, 2020
    Configuration menu
    Copy the full SHA
    3e96b7c View commit details
    Browse the repository at this point in the history

  4. Fixed comment. 

    Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
    @pstibrany
    pstibrany committed May 6, 2020
    Configuration menu
    Copy the full SHA
    2f1b68d View commit details
    Browse the repository at this point in the history

Commits on May 7, 2020

  1. Hide store.caching-bucket.config flags. 

    Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
    @pstibrany
    pstibrany committed May 7, 2020
    Configuration menu
    Copy the full SHA
    c26bd56 View commit details
    Browse the repository at this point in the history

  2. Renamed block to subrange. 

    Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
    @pstibrany
    pstibrany committed May 7, 2020
    Configuration menu
    Copy the full SHA
    db75725 View commit details
    Browse the repository at this point in the history

  3. Renamed block to subrange. 

    Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
    @pstibrany
    pstibrany committed May 7, 2020
    Configuration menu
    Copy the full SHA
    ba3b5d9 View commit details
    Browse the repository at this point in the history

  4. Header 

    Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
    @pstibrany
    pstibrany committed May 7, 2020
    Configuration menu
    Copy the full SHA
    267ce9c View commit details
    Browse the repository at this point in the history

  5. Added TODO 

    Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
    @pstibrany
    pstibrany committed May 7, 2020
    Configuration menu
    Copy the full SHA
    ec564b6 View commit details
    Browse the repository at this point in the history

  6. Removed TODO, in favor of creating issue. 

    Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
    @pstibrany
    pstibrany committed May 7, 2020
    Configuration menu
    Copy the full SHA
    2c21dfe View commit details
    Browse the repository at this point in the history

  7. Use NopCloser. 

    Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
    @pstibrany
    pstibrany committed May 7, 2020
    Configuration menu
    Copy the full SHA
    d1eabf7 View commit details
    Browse the repository at this point in the history