mixin: Fix alert about unhealthy sidecar #2929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hwoarang
force-pushed
the
fix-alert-for-sidecar
branch
7 times, most recently
from
6c4a018
to
6678f08
Compare
kakkoyun
approved these changes
Aug 4, 2020
hwoarang
force-pushed
the
fix-alert-for-sidecar
branch
from
6678f08
to
8960536
Compare
@kakkoyun thank you for the approval. I have just rebased it |
kakkoyun
requested changes
Aug 5, 2020
|
@hwoarang Friendly ping. |
|
@kakkoyun apologies for the delay but due to holidays, connectivity and time are at a premium :) nevertheless I will try to get to it as soon as possible. |
hwoarang
force-pushed
the
fix-alert-for-sidecar
branch
2 times, most recently
from
c82af6d
to
bb529df
Compare
|
@kakkoyun I believe I have addressed all your concerns now |
kakkoyun
reviewed
Aug 12, 2020
The alert was giving the wrong information as the $value contained the number of pods that failing to send heartbeat instead of the actual number of seconds that each sidecar was being unhealthy. Also the 5 minute interval is probably too low as on large deployments prometheus could take much longer to come up online and for sidecar to become actually useful. As such, we can simply subtract the timestamp of the last heartbeat from the current time and fire if we are lagging for more than 10 minutes. Signed-off-by: Markos Chandras <markos@chandras.me>
hwoarang
force-pushed
the
fix-alert-for-sidecar
branch
from
bb529df
to
c3bdfbf
Compare
|
@hwoarang Thanks a lot 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The alert was giving the wrong information as the $value contained
the number of pods that failing to send heartbeat instead of the actual
number of seconds that each sidecar was being unhealthy.
Also the 5 minute interval is probably too low as on large deployments
prometheus could take much longer to come up online and for sidecar to
become actually useful.
As such, we can simply subtract the timestamp of the last heartbeat from
the current time and fire if we are lagging for more than 10 minutes.
This is also consistent with the current unit tests.
Changes
Improve alert for sidecar to provide correct information and not fire too soon
Verification
Deployed locally and did a prometheus update and it did not fire anymore