Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: Reuse operation name constants for consistency #2991

Merged
merged 2 commits into from
Aug 6, 2020

Conversation

kakkoyun
Copy link
Member

@kakkoyun kakkoyun commented Aug 5, 2020

Signed-off-by: Kemal Akkoyun kakkoyun@gmail.com

  • The Changelog entry added.

Verification

  • make test-local

Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
Copy link
Member

@brancz brancz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm on green

@@ -29,12 +29,6 @@ import (
const (
originCache = "cache"
originBucket = "bucket"

opGet = "get"
opGetRange = "getrange"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was actually mismatching what we have already for bucket.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doh! I think we should mention this change in the CHANGELOG

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any mixin / alert we could change?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing, I could find.

@kakkoyun kakkoyun requested a review from pracucci August 6, 2020 14:06
Copy link
Contributor

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I just left a comment about CHANGELOG.

@@ -29,12 +29,6 @@ import (
const (
originCache = "cache"
originBucket = "bucket"

opGet = "get"
opGetRange = "getrange"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doh! I think we should mention this change in the CHANGELOG

Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Let's merge after we check if we can update any mixin (:

@@ -29,12 +29,6 @@ import (
const (
originCache = "cache"
originBucket = "bucket"

opGet = "get"
opGetRange = "getrange"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any mixin / alert we could change?

@kakkoyun
Copy link
Member Author

kakkoyun commented Aug 6, 2020

@bwplotka Mixin seems ok. We don't have any usage. So merging it.

@kakkoyun kakkoyun merged commit 843307a into thanos-io:master Aug 6, 2020
@kakkoyun kakkoyun deleted the resuse_constants branch August 6, 2020 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants