[bucket][tools] Add cleanup subcommand to clean blocks marked for deletion #3092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwplotka
approved these changes
Aug 29, 2020
|
Can you fix DCO? Then we will merge (: You need to sign your commit: https://github.com/thanos-io/thanos/pull/3092/checks?check_run_id=1044012475 |
…etion Signed-off-by: Amr Mahdi <amramahdi@gmail.com>
Signed-off-by: Amr Mahdi <amramahdi@gmail.com>
Signed-off-by: Amr Mahdi <amramahdi@gmail.com>
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is mostly re-using the logic in the compactor to clean up blocks marked for deletion to be in a standalone subcommand that can be used independently of the compactor.
Changes
New
cleanupsubcommand under tools/bucket command.Verification
Verified on actual bucket where there are blobs marked for deletion