Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/reloader: improve detection of directory changes #3136

Merged
merged 2 commits into from
Sep 10, 2020
Merged

pkg/reloader: improve detection of directory changes #3136

merged 2 commits into from
Sep 10, 2020

Commits on Sep 9, 2020

  1. pkg/reloader: improve detection of directory changes 

    When watching for changes in directories, the reloader used to rely only
on the watch interval and not the inotify events. This commit implements
a more efficient detection of changes for watched directories.

The change also adds a new `DelayInterval` option that allows to delay
the config reload after no additional event are received.

Finally a new metric,
`thanos_sidecar_reloader_config_apply_operations_total`, is added and
`thanos_sidecar_reloader_config_apply_errors_total` has been renamed
to `thanos_sidecar_reloader_config_apply_operations_failed_total` for
consistency.

Signed-off-by: Simon Pasquier <spasquie@redhat.com>
    @simonpasquier
    simonpasquier committed Sep 9, 2020
    Configuration menu
    Copy the full SHA
    1ba6383 View commit details
    Browse the repository at this point in the history

  2. Updates after Kemal's review 

    Signed-off-by: Simon Pasquier <spasquie@redhat.com>
    @simonpasquier
    simonpasquier committed Sep 9, 2020
    Configuration menu
    Copy the full SHA
    cf0a868 View commit details
    Browse the repository at this point in the history